Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poncho fix - hides belts beneath poncho #223

Closed
wants to merge 8 commits into from

Conversation

AmoryBlaine
Copy link
Contributor

Ponchos no longer layer below belts. They go above them. Backpacks and suitslot not affected. Thanks to Rock/ForwardNSlash for this fix.

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added something
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
spellcheck: fixed a few typos
ui: changed something relating to user interfaces
code: changed some code
refactor: refactored some code
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
mapadd: added a new map or section to a map
maptweak: tweaked a map
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl:

Ponchos no longer layer below belts. They go above them. Backpacks and suitslot not affected. Thanks to Rock/ForwardNSlash for this fix.
@FslashN
Copy link
Contributor

FslashN commented Apr 8, 2024

I remember that this worked as intended, but the code was more of a workaround since accessories aren't designed with that implementation in mind.

code/modules/clothing/under/ties.dm Outdated Show resolved Hide resolved
code/modules/clothing/under/ties.dm Outdated Show resolved Hide resolved
@@ -557,9 +557,20 @@ Applied by gun suicide and high impact bullet executions, removed by rejuvenate,
K = marine_armor.armor_overlays[i]
if(K)
if(!IMG)
IMG = image(K.icon,src,K.icon_state, "layer"= -SUIT_GARB_LAYER)
if(istype(K, /obj/item/clothing/accessory))
var/obj/item/clothing/accessory/A = K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

else
IMG.overlays += image(K.icon,src,K.icon_state, "layer"= -SUIT_GARB_LAYER)
if(istype(K, /obj/item/clothing/accessory))
var/obj/item/clothing/accessory/A = K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@morrowwolf morrowwolf marked this pull request as draft April 18, 2024 06:02
harryob-test pushed a commit that referenced this pull request May 23, 2024
@AmoryBlaine AmoryBlaine deleted the poncho-layer-fix branch June 18, 2024 18:11
@AmoryBlaine AmoryBlaine restored the poncho-layer-fix branch June 18, 2024 18:11
@AmoryBlaine AmoryBlaine reopened this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants