Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy Pulse RIfle Rework #298

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
03aab63
first step, gives HPR FA and makes HT go away from the cases.
Apr 3, 2024
d825fcd
probably working bipod need to debug later
Jun 16, 2024
32fab2e
Merge branch 'master' into heavy-pulse-rifle-buff
KoishiVibe Jun 20, 2024
6350dee
bugsquishing
Jun 22, 2024
72f54fd
more bugfixing
Jun 22, 2024
0036720
Merge remote-tracking branch 'upstream/master' into heavy-pulse-rifle…
Jun 22, 2024
d95812a
makes the magazines fit into backpacks and gen pouches but not the am…
Jun 22, 2024
000537e
maybe nerfed right
KoishiVibe Jun 25, 2024
6feeb1c
new sprites
KoishiVibe Jun 25, 2024
15fd8b4
attachment fix?
KoishiVibe Jun 25, 2024
6638733
ok working now
KoishiVibe Jun 25, 2024
657bd64
Merge remote-tracking branch 'upstream/master' into heavy-pulse-rifle…
KoishiVibe Jun 25, 2024
1dc7ee0
commonalizes the sprites and also improves the sprite. thanks dong!!!
KoishiVibe Jun 25, 2024
3b4e2c1
Merge branch 'master' into heavy-pulse-rifle-buff
KoishiVibe Jun 28, 2024
bf2a6bb
Emergenvy nerf lmao
KoishiVibe Jul 8, 2024
0217d8e
Refactors the machinegun box to be with all the other machineguns. It…
KoishiVibe Jul 8, 2024
53267e4
additional balancing
KoishiVibe Jul 8, 2024
4492278
fuck. Ok, this isn;t a varuiable.
KoishiVibe Jul 8, 2024
37648e6
Merge branch 'master' into heavy-pulse-rifle-buff
KoishiVibe Jul 8, 2024
ff71c36
fixes for damage, ammo type of base magazine. minor flavor text change.
KoishiVibe Jul 9, 2024
b2c1f55
Merge branch 'heavy-pulse-rifle-buff' of https://github.com/KoishiVib…
KoishiVibe Jul 9, 2024
3887650
Merge branch 'PvE-CMSS13:master' into heavy-pulse-rifle-buff
KoishiVibe Jul 9, 2024
793e5d5
see if this makes it more of a proper sidegrade or not
KoishiVibe Aug 14, 2024
8350f46
fuck it this is good enough
KoishiVibe Aug 14, 2024
ae9b7a1
Synchronization
Nov 13, 2024
a477d15
replaces new instances of ammobox
Nov 13, 2024
cf9679f
might break the tac and army variants. will work on those later.
Nov 13, 2024
a04b0d5
ok last change. then i can test and see how it feels.
Nov 13, 2024
e59793c
additional modifications. defines a couple vars.
Nov 13, 2024
0ec6b8b
so that was a fucking lie
Nov 13, 2024
4f21bf8
hopefully fixes issue
Nov 15, 2024
8b30b8d
maybe fixes phantom var?
Nov 15, 2024
1e94bff
Merge branch 'master' into heavy-pulse-rifle-buff
KoishiVibe Nov 15, 2024
6f2ad76
fuck
Nov 15, 2024
af7c3f4
Merge branch 'heavy-pulse-rifle-buff' of https://github.com/KoishiVib…
Nov 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions code/modules/cm_marines/equipment/guncases.dm
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,15 @@
//------------
/obj/item/storage/box/guncase/lmg
name = "\improper M41AE2 heavy pulse rifle case"
desc = "A gun case containing the M41AE2 heavy pulse rifle. You can get additional ammunition at requisitions."
storage_slots = 5
desc = "A plastic hard weapon case containing the M41AE2 Heavy Pulse Rifle and three magazines."
storage_slots = 4
can_hold = list(/obj/item/weapon/gun/rifle/lmg, /obj/item/ammo_magazine/rifle/lmg)

/obj/item/storage/box/guncase/lmg/fill_preset_inventory()
new /obj/item/weapon/gun/rifle/lmg(src)
new /obj/item/ammo_magazine/rifle/lmg(src)
new /obj/item/ammo_magazine/rifle/lmg/holo_target(src)
new /obj/item/attachable/flashlight
new /obj/item/attachable/bipod
new /obj/item/ammo_magazine/rifle/lmg(src)
new /obj/item/ammo_magazine/rifle/lmg(src)

//------------
/obj/item/storage/box/guncase/m41aMK1
Expand Down
21 changes: 21 additions & 0 deletions code/modules/projectiles/gun_attachables.dm
Original file line number Diff line number Diff line change
Expand Up @@ -3357,6 +3357,8 @@ Defined in conflicts.dm of the #defines folder.
burst_scatter_mod = -SCATTER_AMOUNT_TIER_8
if(istype(G,/obj/item/weapon/gun/rifle/sniper/M42A))
delay_mod = -FIRE_DELAY_TIER_7
else if(istype(G,/obj/item/weapon/gun/rifle/lmg))
delay_mod = 0
else
delay_mod = -FIRE_DELAY_TIER_12
G.recalculate_attachment_bonuses()
Expand Down Expand Up @@ -3405,6 +3407,25 @@ Defined in conflicts.dm of the #defines folder.
return O2
return 0

/obj/item/attachable/bipod/integral
name = "integral bipod"
desc = "An integral bipod for the M41AE2 Heavy Pulse Rifle."
icon_state = "bipod"
attach_icon = "bipod_a"
slot = "under"
size_mod = 0
melee_mod = 0
flags_attach_features = ATTACH_ACTIVATION
attachment_action_type = /datum/action/item_action/toggle

/obj/item/attachable/bipod/integral/New()
..()

delay_mod = 0
wield_delay_mod = WIELD_DELAY_FAST
accuracy_mod = -HIT_ACCURACY_MULT_TIER_5
scatter_mod = SCATTER_AMOUNT_TIER_9
recoil_mod = RECOIL_AMOUNT_TIER_5

/obj/item/attachable/bipod/m60
name = "bipod"
Expand Down
24 changes: 12 additions & 12 deletions code/modules/projectiles/guns/rifles.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1231,49 +1231,49 @@

/obj/item/weapon/gun/rifle/lmg
name = "\improper M41AE2 heavy pulse rifle"
desc = "A large squad support weapon capable of laying down sustained suppressing fire from a mounted position. While unstable and less accurate, it can be lugged and shot with two hands. Like it's smaller brothers, the M41A MK2 and M4RA, the M41AE2 is chambered in 10mm."
desc = "An LMG variant of the M41A. Offers greater sustained firepower at the cost of a grenade launcher, and some handling."
icon = 'icons/obj/items/weapons/guns/guns_by_faction/uscm.dmi'
icon_state = "m41ae2"
item_state = "m41ae2"

reload_sound = 'sound/weapons/handling/hpr_reload.ogg'
unload_sound = 'sound/weapons/handling/hpr_unload.ogg'
fire_sound = 'sound/weapons/gun_hpr.ogg'
fire_sound = "gun_pulse"
aim_slowdown = SLOWDOWN_ADS_LMG
current_mag = /obj/item/ammo_magazine/rifle/lmg
attachable_allowed = list(
/obj/item/attachable/suppressor,
/obj/item/attachable/reddot,
/obj/item/attachable/reflex,
/obj/item/attachable/verticalgrip,
/obj/item/attachable/angledgrip,
/obj/item/attachable/flashlight/grip,
/obj/item/attachable/flashlight,
/obj/item/attachable/bipod,
/obj/item/attachable/bipod/integral,
/obj/item/attachable/stock/rifle/collapsible,
/obj/item/attachable/heavy_barrel,
/obj/item/attachable/compensator,
/obj/item/attachable/burstfire_assembly,
/obj/item/attachable/magnetic_harness,
)
starting_attachment_types = list(/obj/item/attachable/bipod/integral, /obj/item/attachable/stock/rifle/collapsible)

flags_gun_features = GUN_CAN_POINTBLANK|GUN_AMMO_COUNTER|GUN_WIELDED_FIRING_ONLY|GUN_SUPPORT_PLATFORM
flags_gun_features = GUN_CAN_POINTBLANK|GUN_AMMO_COUNTER
gun_category = GUN_CATEGORY_HEAVY
start_automatic = TRUE

/obj/item/weapon/gun/rifle/lmg/set_gun_attachment_offsets()
attachable_offset = list("muzzle_x" = 33, "muzzle_y" = 19,"rail_x" = 10, "rail_y" = 23, "under_x" = 23, "under_y" = 12, "stock_x" = 24, "stock_y" = 12)


/obj/item/weapon/gun/rifle/lmg/set_gun_config_values()
..()
set_fire_delay(FIRE_DELAY_TIER_LMG)
set_burst_amount(BURST_AMOUNT_TIER_5)
set_burst_delay(FIRE_DELAY_TIER_LMG)
set_fire_delay(FIRE_DELAY_TIER_11)
set_burst_amount(BURST_AMOUNT_TIER_4)
set_burst_delay(FIRE_DELAY_TIER_11)
fa_scatter_peak = FULL_AUTO_SCATTER_PEAK_TIER_3
fa_max_scatter = SCATTER_AMOUNT_TIER_4
accuracy_mult = BASE_ACCURACY_MULT
accuracy_mult_unwielded = BASE_ACCURACY_MULT - HIT_ACCURACY_MULT_TIER_10
scatter = SCATTER_AMOUNT_TIER_6
burst_scatter_mult = SCATTER_AMOUNT_TIER_5
scatter = SCATTER_AMOUNT_TIER_8
burst_scatter_mult = SCATTER_AMOUNT_TIER_7
scatter_unwielded = SCATTER_AMOUNT_TIER_2
damage_mult = BASE_BULLET_DAMAGE_MULT
recoil_unwielded = RECOIL_AMOUNT_TIER_1
Expand Down
4 changes: 3 additions & 1 deletion code/modules/projectiles/magazines/rifles.dm
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,14 @@
flags_magazine = AMMUNITION_CANNOT_REMOVE_BULLETS|AMMUNITION_REFILLABLE|AMMUNITION_SLAP_TRANSFER
ammo_band_icon = "+m41ae2_band"
ammo_band_icon_empty = "+m41ae2_band_e"
w_class = SIZE_LARGE
reload_delay = 5

/obj/item/ammo_magazine/rifle/lmg/holo_target
name = "\improper M41AE2 ammo box (10x24mm holo-target)"
desc = "A semi-rectangular box of holo-target rounds for the M41AE2 Heavy Pulse Rifle."
default_ammo = /datum/ammo/bullet/rifle/holo_target
max_rounds = 200
max_rounds = 300
ammo_band_color = AMMO_BAND_COLOR_HOLOTARGETING

/obj/item/ammo_magazine/rifle/lmg/heap
Expand Down
Loading