Ports "Quadtree Shapes" and fix #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional shapes available for testing against quadtrees or elsewhere: square, ellipse, circle. Square is a simplified version of the rectangle, circle is a simplified version of the ellipse. Cleaned up existing code for shapes (rectangles), should be better documented and easier to read. Where possible converted existing RECT usage to SQUARE (everything was squares anyway). Where possible loosened defined types to the base `/datum/shape` so shape types can be swapped as desired. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Should (currently) have no effect on the game, but paves the way for more interesting uses for quadtrees. Circular areas of effect, for instance. Boots. Sentries, flamer sentries, bell towers, flags, sentry laptop, motion detector, and egg morpher all appear to work as intended. No player facing changes.
# About the pull request Quadtrees pr did that, soo uhh bbadd?? fixes #6744 fixes #6733 <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game deaf marines bad (and xenos is bad) # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Surgery sound and alike is fixed /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Ports cmss13-devs/cmss13#6681 and cmss13-devs/cmss13#6745 , adds additional options for quadtree shapes.
Explain why it's good for the game
Should (currently) have no effect on the game, but paves the way for more interesting uses for quadtrees. Circular areas of effect, for instance. More performant mob/client finding.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
No player facing changes.