Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports "Quadtree Shapes" and fix #336

Merged
merged 2 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. Quadtrees shapes (#6681)

    Additional shapes available for testing against quadtrees or elsewhere:
    square, ellipse, circle. Square is a simplified version of the
    rectangle, circle is a simplified version of the ellipse.
    Cleaned up existing code for shapes (rectangles), should be better
    documented and easier to read.
    Where possible converted existing RECT usage to SQUARE (everything was
    squares anyway).
    Where possible loosened defined types to the base `/datum/shape` so
    shape types can be swapped as desired.
    
    <!-- Remove this text and explain what the purpose of your PR is.
    
    Mention if you have tested your changes. If you changed a map, make sure
    you used the mapmerge tool.
    If this is an Issue Correction, you can type "Fixes Issue #169420" to
    link the PR to the corresponding Issue number #169420.
    
    Remember: something that is self-evident to you might not be to others.
    Explain your rationale fully, even if you feel it goes without saying.
    -->
    
    Should (currently) have no effect on the game, but paves the way for
    more interesting uses for quadtrees. Circular areas of effect, for
    instance.
    Boots. Sentries, flamer sentries, bell towers, flags, sentry laptop,
    motion detector, and egg morpher all appear to work as intended.
    
    No player facing changes.
    Doubleumc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1dbd41b View commit details
    Browse the repository at this point in the history
  2. Sound range (#6745)

    # About the pull request
    Quadtrees pr did that, soo uhh bbadd??
    fixes #6744 
    fixes #6733
    <!-- Remove this text and explain what the purpose of your PR is.
    
    Mention if you have tested your changes. If you changed a map, make sure
    you used the mapmerge tool.
    If this is an Issue Correction, you can type "Fixes Issue #169420" to
    link the PR to the corresponding Issue number #169420.
    
    Remember: something that is self-evident to you might not be to others.
    Explain your rationale fully, even if you feel it goes without saying.
    -->
    
    # Explain why it's good for the game
    deaf marines bad (and xenos is bad)
    # Testing Photographs and Procedure
    <details>
    <summary>Screenshots & Videos</summary>
    
    Put screenshots and videos here with an empty line between the
    screenshots and the `<details>` tags.
    
    </details>
    
    
    # Changelog
    :cl:
    fix: Surgery sound and alike is fixed
    /:cl:
    kiVts authored and Doubleumc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2e7388d View commit details
    Browse the repository at this point in the history