US Armed Forces update 3 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubleumc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes an oversight in skills amongst the US Army & USASF gear presets, giving them the skills they're meant to have without the adjusted default values for skills here on PVE messing with it
Also fixed an issue with the USASF synth's faction var.
Next up is an expansion to the Army's available roles, squad icons for them so props know who is who in the field and potentially the same for the USASF roles.
Explain why it's good for the game
US Army props were designed around better equipment, worse skills, but prior to this PR they were just overall better equipped marines in terms of how they played. This should adress that, bringing them in-line with the vision I initially had for them. The USASF skills were adjusted too after realising this was an issue so they too do not benefit from the enhanced default skills
Changelog
🆑
add: Adds new 0-value defines for skills that were missing them after the skill_default changes
qol: USASF Synthetic no longer freaks sentry guns out, they're directly marked as being part of the Marine FACTION_GROUP
fix: Fixes the skills for US Army & various USASF presets
/:cl: