Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal Tarp V2 Spam Entering/Exiting #3734

Closed
3 tasks done
Reisyns opened this issue Jun 27, 2023 · 0 comments · Fixed by #3768
Closed
3 tasks done

Thermal Tarp V2 Spam Entering/Exiting #3734

Reisyns opened this issue Jun 27, 2023 · 0 comments · Fixed by #3768
Labels
In Game Exploit If you abuse this, you will be obliterated

Comments

@Reisyns
Copy link

Reisyns commented Jun 27, 2023

Testmerges

#3601, #3298, #3644, #3676, #3666

Description of the bug

Thermal Tarp V2 (and likely any other tarps) are able to be spammed to enter or exit to prevent other mobs like xenos from interacting with the occupant whilst the occupant is able to continue to spam whilst attacking the other mob and is even able to open and close the tarp whilst laying down. As a result, it can be abused to create situations as seen below.

https://cdn.discordapp.com/attachments/1113937096554598581/1123130186641178664/retard_tarp.mp4

What's the difference with what should have happened?

Some sort of delaying between entering or exiting or re-entering a tarp and not being able to interact with it whilst resting.

How do we reproduce this bug?

1.Enter tarp
2.Other mob opens tarp
3.You spam tarp to keep yourself in it.
...

Issue Bingo

@Reisyns Reisyns added the Bug Admin events aren't bugs label Jun 27, 2023
@ItsVyzo ItsVyzo added In Game Exploit If you abuse this, you will be obliterated and removed Bug Admin events aren't bugs labels Jun 27, 2023
github-merge-queue bot pushed a commit that referenced this issue Jun 30, 2023
# About the pull request

Fixes #3734
Deals with exploit that allows the user to spam open and close a tarp,
making it hard for the Xeno to hit the marine, this makes it so when
tarp is opened, 3 seconds must pass before it can be closed again. If 3
seconds isn't enough, delay can be lengthened.

# Explain why it's good for the game

I was tasked by the Xeno Agents to buff Xeno win rate by any means
necessary, including fixing exploits.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/91219575/999e0f72-a802-41d3-b1d8-5a4569d84e5a

Before


![image](https://github.com/cmss13-devs/cmss13/assets/91219575/7eb71b25-4077-4042-bab6-760f0c429190)
After

</details>


# Changelog
:cl:
fix: fixes exploit relating to cloaking tarps by adding a delay before
tarp can be closed again.
/:cl:

---------

Co-authored-by: harryob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Game Exploit If you abuse this, you will be obliterated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants