Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weeds dont break when NON-RESIN walls are broken #5135

Closed
3 tasks done
ihatethisengine opened this issue Dec 6, 2023 · 1 comment · Fixed by #5150
Closed
3 tasks done

Weeds dont break when NON-RESIN walls are broken #5135

ihatethisengine opened this issue Dec 6, 2023 · 1 comment · Fixed by #5150
Assignees
@Birdtalon
Labels
Confirmed Bug We have the same at home!

Comments

@ihatethisengine
Copy link
Contributor

Testmerges

#4986: 'Projectile smooth movement' by Doubleumc at commit f405a0a #4939: 'Adds Latejoin scaling to Vendors and ASRS' by fira at commit 23c24bc #5054: 'Egg Changes' by Zonespace27 at commit ecf4515 #4842: '/tg/ Status Effects Part 2 - datum, KD, KO, Stuns' by fira at commit 572fdd5 #5067: 'Return Ice Classic to CM for the Holiday Season' by BroseidonMOO at commit a9a096e #5018: 'ASRS Supply Pools -- Crates Carryover and MessTech supply' by fira at commit cb7e930 #5127: 'Forest Bugfix Bundle' by realforest2001 at commit 9bd58fd #5134: 'DEBUG: src.pulledby.pulling == src' by fira at commit 0e4b35b

Round ID

19826

Description of the bug

Weeds dont break when NON-RESIN walls they attached to are broken, they just stay as if nothing happening, making it very confusing for everyone.
2023-12-06_10-42-42

99% this broke it: #5096

What's the difference with what should have happened?

Weeds should disappear. Or at least change sprite to "attached to ground".

How do we reproduce this bug?

  1. Weed near a wall
  2. Wait till the wall is weeded
  3. Break the wall
    ...

Issue Bingo
@ihatethisengine ihatethisengine added the Bug Admin events aren't bugs label Dec 6, 2023
@Birdtalon Birdtalon self-assigned this Dec 6, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Dec 6, 2023

i can confirm that last PR that work on walls was
#5096
i think

@Huffie56 Huffie56 added Confirmed Bug We have the same at home! and removed Bug Admin events aren't bugs labels Dec 6, 2023
@Birdtalon Birdtalon mentioned this issue Dec 6, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2023
@Birdtalon
Weeds on destroyed non resin walls now delete as previously (#5150)
5fecff8 
# About the pull request

#5096 left "weed walls" behind when non resin walls are destroyed. This
reintroduces the check but narrows it to only
`/obj/effect/alien/weeds/weedwall` so normal "floor weeds" are still
unaffected. But "wall weeds" will die...

Fixes #5135 

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Wall weeds now destroyed when closed wall turfs are changed.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Birdtalon Birdtalon

Labels
Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Weeds on destroyed non resin walls now delete as previously Birdtalon/cmss13
3 participants
@Birdtalon @ihatethisengine @Huffie56