Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weeds on destroyed non resin walls now delete as previously #5150

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Dec 6, 2023

About the pull request

#5096 left "weed walls" behind when non resin walls are destroyed. This reintroduces the check but narrows it to only /obj/effect/alien/weeds/weedwall so normal "floor weeds" are still unaffected. But "wall weeds" will die...

Fixes #5135

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Wall weeds now destroyed when closed wall turfs are changed.
/:cl:

@Birdtalon Birdtalon changed the title Weeds on destroyed walls now delete as previously Weeds on destroyed non resin walls now delete as previously Dec 6, 2023
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 6, 2023
@harryob harryob added this pull request to the merge queue Dec 7, 2023
Merged via the queue into cmss13-devs:master with commit 5fecff8 Dec 7, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Dec 7, 2023
@Birdtalon Birdtalon deleted the weedwalls branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weeds dont break when NON-RESIN walls are broken
3 participants