Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character unable to move/not responding to keyboard movement inputs #5420

Closed
1 of 3 tasks
CopperKast opened this issue Jan 11, 2024 · 4 comments · Fixed by #5464
Closed
1 of 3 tasks

Character unable to move/not responding to keyboard movement inputs #5420

CopperKast opened this issue Jan 11, 2024 · 4 comments · Fixed by #5464
Labels
Confirmed Bug We have the same at home!

Comments

@CopperKast
Copy link

Testmerges

N/A to my knowlage

Round ID

20343

Description of the bug

During evac, I had died to a ravager while reviving another marine, during my mauling I was unable to move and subsequently died. I was revived by another medic on the trip back up to the Almayer where I was unable to move but could equip/unequip and look around directionally with my cursor. I had to be dragged off the alamo and after a moment or two of struggling I pinged an admin who suggested fixes that unfortunately had no effect on my problem. buckling to a folding chair nearby, disconnecting and rejoining, and giving them control of my character to see if it was a client-side issue. eventually I requested the admin delete/cryo my character body so I could sit out the hijack where I found my ghost was able to freely move about unlike my body. I'm not sure if its unrelated or not but I have been experiencing beyond crashes whenever a crate landed at fob for this round.
Beyond version 515.1625 stable branch

What's the difference with what should have happened?

I would assume expected behavior would be my character moving in response to my keyboard input WASD ect.

How do we reproduce this bug?

  1. die on alamo before takeoff, specifically one tile to the left of the last left inboard row of seats
    2.have your revive defib interrupted by the alamo landing then be revived successfully after which.
    3.I don't know if its reproduceable but this was pretty much the string of events the "anchored" me
    ...

Issue Bingo
@CopperKast CopperKast added the Bug Admin events aren't bugs label Jan 11, 2024
@Birdtalon
Copy link
Contributor

Possibly the same as #5387

@Birdtalon Birdtalon added the Needs Reproducing We're not even sure if you know how to do it label Jan 11, 2024
@CopperKast
Copy link
Author

Possibly the same as #5387

It looks about the same, although I was attacked by a ravager while buckled instead of a warrior.

@ItsVyzo ItsVyzo mentioned this issue Jan 11, 2024
Closed
3 tasks
@ItsVyzo
Copy link
Contributor

ItsVyzo commented Jan 11, 2024

This is most likely related to using BYOND 515, will mark as BYOND Issue for now

@ItsVyzo ItsVyzo added the BYOND issue I'm limited by the technology of 1997 label Jan 11, 2024
@VileBeggar
Copy link
Contributor

just happened to me at round 20367. was buckled in during evac and was promptly lunged by a warrior. couldn't move at all and trying to buckle gave me the message "You are unable to do this in your current state." though, this is probably a separate issue in itself

@Birdtalon Birdtalon added Confirmed Bug We have the same at home! and removed BYOND issue I'm limited by the technology of 1997 Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it labels Jan 15, 2024
@Birdtalon Birdtalon mentioned this issue Jan 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
@Birdtalon
Fixes mobs unable to move after being flung while buckled. (#5464)
07405df 
# About the pull request

Buckled mobs didn't have their `TRAIT_IMMOBILIZED` removed properly
since we return early from `launch_towards()` if `buckled`

https://github.com/cmss13-devs/cmss13/blob/939e283561d2446d5df4b60faba08097eaea1f79/code/modules/mob/living/living.dm#L401-L405

Therefore any callbacks in end_throw_callbacks are never invoked. In the
case of xeno throws we rely on end_throw_callbacks to remove our
immobilised trait

Fixes #5420

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Fixed buckled mobs unable to move after being thrown by a xeno.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes mobs unable to move after being flung while buckled. Birdtalon/cmss13
4 participants
@VileBeggar @Birdtalon @ItsVyzo @CopperKast