Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mobs unable to move after being flung while buckled. #5464

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Jan 15, 2024

About the pull request

Buckled mobs didn't have their TRAIT_IMMOBILIZED removed properly since we return early from launch_towards() if buckled

/mob/living/launch_towards(datum/launch_metadata/LM)
if(src)
SEND_SIGNAL(src, COMSIG_MOB_MOVE_OR_LOOK, TRUE, dir, dir)
if(!istype(LM) || !LM.target || !src || buckled)
return

Therefore any callbacks in end_throw_callbacks are never invoked. In the case of xeno throws we rely on end_throw_callbacks to remove our immobilised trait

Fixes #5420

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixed buckled mobs unable to move after being thrown by a xeno.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 15, 2024
@Drulikar Drulikar marked this pull request as draft January 16, 2024 05:47
@Birdtalon Birdtalon assigned Birdtalon and unassigned Birdtalon Jan 16, 2024
@Birdtalon Birdtalon marked this pull request as ready for review January 16, 2024 10:01
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine.

@Birdtalon Birdtalon mentioned this pull request Jan 16, 2024
3 tasks
@Bagpepos Bagpepos mentioned this pull request Jan 17, 2024
3 tasks
@harryob harryob added this pull request to the merge queue Jan 17, 2024
Merged via the queue into cmss13-devs:master with commit 07405df Jan 17, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 17, 2024
@Birdtalon Birdtalon deleted the xenolaunch branch February 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character unable to move/not responding to keyboard movement inputs
3 participants