Overwatch Signals for QDEL: Less client disconnection? #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
approved these changes
May 30, 2023
|
I haven't noticed disconnection when overwatching using the overwatch console in CIC, and that should be the same process as the ghost overwatch, shouldn't it? |
Watermelon914
requested changes
Jun 3, 2023
|
#3525 might be a more comprehensive fix unless that's yet another different 515 flaw. |
cm13-github
added a commit
that referenced
this pull request
Jun 4, 2023
morrowwolf
pushed a commit
that referenced
this pull request
Jun 7, 2023
# About the pull request Followup to #3477. # Explain why it's good for the game  # Changelog :cl: fix: Queen Eye no longer repeatedly throws runtime errors. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is sort of a stab in the dark to fix #3444 by making marine and xeno overwatching register a signal for qdeletion to end the overwatch faster. The actual source of this issue is apparently that the multithreaded map tick beta has an issue with crashing clients, so the changes made in this PR don't need to be permanent if the effect isn't as desirable when the beta is fixed.
Locally testing has not been able to reproduce the problem, but I can confirm I do not get the momentary blank screen when overwatching something that gets deleted.
Explain why it's good for the game
Hopefully no more (or less) client disconnections when overwatching something that gets deleted.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Clients should hopefully avoid disconnection when observing someone that is deleted.
/:cl: