-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port /tg/ PR #75835 - Linux 515 fcopy() crash fix #3525
Conversation
Glad I added that 515 unit test; though also failing on TG too. Likely not worth merging until they sort out why or can confirm for sure that all those errors somehow are false positives. |
Whathefuk... |
Looks like Walter's edit should be viable. |
Indeed. I don't know why I thought fexists() would work with RSC bundled resources... |
This still seems kinda unstable. So character panel never ended up loading in the human model, and each time it was opened it would incrementally add in more clothes sprites. Everything else seemed fine, expect that it then proceeded to crash or disconnect (ending the debug run) after a few minutes after round start. These were the errors I experienced related to the character panel: Its not obvious yet what caused a crash/disconnection though. I was using 515.1606. Will try again using 515.1608. Still crashes/disconnects, though this time preferences panel seemed to be working other than client/server console spamming |
I'm not sure these are related, it all reads out as a null mob. Intriguing though... |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Details here: tgstation/tgstation#75835