Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port /tg/ PR #75835 - Linux 515 fcopy() crash fix #3525

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

fira
Copy link
Member

@fira fira commented Jun 3, 2023

@fira fira added Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players GBP: No Update labels Jun 3, 2023
@Drulikar
Copy link
Contributor

Drulikar commented Jun 3, 2023

Glad I added that 515 unit test; though also failing on TG too. Likely not worth merging until they sort out why or can confirm for sure that all those errors somehow are false positives.

@Drulikar
Copy link
Contributor

Drulikar commented Jun 3, 2023

I can confirm they are not false positives:
image
You just don't get icons in TGUI.

@Drulikar Drulikar marked this pull request as draft June 3, 2023 19:49
@fira
Copy link
Member Author

fira commented Jun 3, 2023

Whathefuk...

@fira fira added Do Not Merge If you merge this PR, I will annihilate you and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Jun 3, 2023
@Drulikar
Copy link
Contributor

Drulikar commented Jun 4, 2023

Looks like Walter's edit should be viable.

@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jun 4, 2023
@fira
Copy link
Member Author

fira commented Jun 4, 2023

Indeed. I don't know why I thought fexists() would work with RSC bundled resources...

@Drulikar
Copy link
Contributor

Drulikar commented Jun 4, 2023

This still seems kinda unstable. So character panel never ended up loading in the human model, and each time it was opened it would incrementally add in more clothes sprites. Everything else seemed fine, expect that it then proceeded to crash or disconnect (ending the debug run) after a few minutes after round start. These were the errors I experienced related to the character panel:
dd.log

Its not obvious yet what caused a crash/disconnection though. I was using 515.1606. Will try again using 515.1608.

Still crashes/disconnects, though this time preferences panel seemed to be working other than client/server console spamming winset: Parameter preferencebrowser.on-close not found. Settings don't seem to stick either.

@fira
Copy link
Member Author

fira commented Jun 4, 2023

I'm not sure these are related, it all reads out as a null mob. Intriguing though...
In any case this is meant primarily for TM to the Linux server so we can find out what happens there

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 12, 2023
@github-actions github-actions bot closed this Jun 20, 2023
@harryob harryob reopened this Jun 28, 2023
@harryob harryob removed the Stale beg a maintainer to review your PR label Jun 28, 2023
@harryob harryob removed the Do Not Merge If you merge this PR, I will annihilate you label Jun 29, 2023
@harryob harryob marked this pull request as ready for review June 29, 2023 08:44
@harryob harryob added this pull request to the merge queue Jun 29, 2023
Merged via the queue into cmss13-devs:master with commit ae54d1f Jun 29, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more GBP: No Update Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants