Mines Boom: The PR #3615
Mines Boom: The PR #3615
Conversation
Co-authored-by: carlarctg <[email protected]>
…ss13 into cmss13/mineRefractor
|
You currently have a negative Fix/Feature pull request delta of -11. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
github-actions
bot
added
Sprites
| if(heavy_trigger && buried) | ||
| playsound(loc, 'sound/weapons/flipblade.ogg', 35, 1) | ||
| if(isxeno(unfortunate_soul)) | ||
| var/mob/living/carbon/xenomorph/xeno = unfortunate_soul |
There was a problem hiding this comment.
You don't need to cast to xeno if all you're doing is checking the mob_size
There was a problem hiding this comment.
But it triggers if someone is heavy enough, the check is so that T1s/Small xenos don't trigger it.
There was a problem hiding this comment.
You can check mob_size of any mob, you don't have to make it a /mob/living/carbon/xenomorph variable
| unfortunate_soul.visible_message(SPAN_DANGER("[icon2html(src, viewers(src))] [name] clicks as [unfortunate_soul] moves on top of it."), \ | ||
| SPAN_DANGER("[icon2html(src, unfortunate_soul)] [name] clicks as you move on top of it."), \ | ||
| SPAN_DANGER("You hear a click.")) |
There was a problem hiding this comment.
Looks like a leftover? This seems like it should already be done by heavy_trigger_notify
| user.visible_message(SPAN_WARNING("[user] stops burying [src]."), \ | ||
| SPAN_WARNING("You stop burying [src].")) | ||
| return | ||
| user.visible_message(SPAN_NOTICE("[user] finished burying [src]."), \ |
There was a problem hiding this comment.
check again for anchored/active/buried/needs_digging (or whichever are appropriate) post do_after here
There was a problem hiding this comment.
You do checks to verify the mine is in a valid state to be burried.
But if for example several persons do it at same time, the state of the mine could be incorrect after the period waited in do_after.
So you need to re-check the mine is in a proper state after the wait to make sure the action is still valid
There was a problem hiding this comment.
Similar to what's done just below for disarming with if(!active)//someone beat us to it
Co-authored-by: fira <[email protected]>
Co-authored-by: fira <[email protected]>
| user.visible_message(SPAN_WARNING("[user] stops burying [src]."), \ | ||
| SPAN_WARNING("You stop burying [src].")) | ||
| return | ||
| user.visible_message(SPAN_NOTICE("[user] finished burying [src]."), \ |
There was a problem hiding this comment.
You do checks to verify the mine is in a valid state to be burried.
But if for example several persons do it at same time, the state of the mine could be incorrect after the period waited in do_after.
So you need to re-check the mine is in a proper state after the wait to make sure the action is still valid
| user.visible_message(SPAN_WARNING("[user] stops burying [src]."), \ | ||
| SPAN_WARNING("You stop burying [src].")) | ||
| return | ||
| user.visible_message(SPAN_NOTICE("[user] finished burying [src]."), \ |
There was a problem hiding this comment.
Similar to what's done just below for disarming with if(!active)//someone beat us to it
| if(heavy_trigger && buried) | ||
| playsound(loc, 'sound/weapons/flipblade.ogg', 35, 1) | ||
| if(isxeno(unfortunate_soul)) | ||
| var/mob/living/carbon/xenomorph/xeno = unfortunate_soul |
There was a problem hiding this comment.
You can check mob_size of any mob, you don't have to make it a /mob/living/carbon/xenomorph variable
| arming_time = 3 SECONDS | ||
| use_dir = FALSE | ||
| unacidable = TRUE | ||
| var/datum/effect_system/spark_spread/sparks = new |
There was a problem hiding this comment.
you can 't do = new here statically, new it where appropriate to use
…into mineRefractor
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
This PR is a finalization of initial code from Totalepicness5. This PR adds antitank mines as an alternative/additive to claymores that target larger xenos.
Explain why it's good for the game
It offers a defensive/ambush utility to engineers that can be countered by xenos (dug up and acid'd) but that deters T3s.
(gonna write some more later I think, but it's sat in my tabs for like 8 hours already)
Testing Photographs and Procedure
The code hasn't changed but the placeholder sprite is kil
video
Changelog
🆑
add: Adds anti tank mines and the framework for creating more bury-able mine types.
balance: Adds M19 Antitank mines to the engineer vendor, the req vendor with a scale of (round * 2), adds the M19 antitank mine.
spellcheck: ((title suggested by Silencer_pl)) Added descriptions for the Antitank Mine.
code: Original code by Totalepicness5, maintenance of the code by LynxSolstice.
refactor: Mine code flesh out more. (Refactor by Totalepicness5)
imageadd: Adds a sprite for an unburied and a buried Antitank Mine (Sprites by Thwomper)
/:cl: