Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xeno structures/weeds become forsaken after hijack #3685

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Jun 20, 2023

About the pull request

This PR makes groundside xeno structures and weeds become forsaken after hijack.

With blessing, finishing this up for the author of this: #3630

Explain why it's good for the game

It is annoying to try and fight through all traps and such to go and do stuff as a forsaken xeno.

I would just hardcode ally but some people enjoy the XvX that sometimes occurs.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Newyearnewme, Morrow
add: Xeno structures/weeds now become forsaken after hijack
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 20, 2023
@WolfOrion
Copy link

image
image

While they do change color and do seem to prevent traps from going off, they still slow you down, don't provide health or plasma regeneration, and you can't build on them. You can't destroy the nodes either. It's really weird.

@morrowwolf morrowwolf marked this pull request as draft June 22, 2023 05:31
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 30, 2023
@morrowwolf morrowwolf removed the Stale beg a maintainer to review your PR label Jul 5, 2023
@morrowwolf morrowwolf marked this pull request as ready for review July 5, 2023 14:44
@morrowwolf
Copy link
Member Author

Aaaand last check for broken shit

@morrowwolf morrowwolf added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Jul 5, 2023
@harryob harryob added this pull request to the merge queue Jul 5, 2023
Merged via the queue into cmss13-devs:master with commit fb617ea Jul 5, 2023
cm13-github added a commit that referenced this pull request Jul 5, 2023
github-actions bot added a commit that referenced this pull request Jul 5, 2023
@morrowwolf morrowwolf deleted the forsaken-handling branch July 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants