Fix Tableflip scanning logic + infinite loop #3740
Conversation
There was a problem hiding this comment.
I was able to reproduce the examples you mentioned, and this PR does resolve them. Though its still kinda weird that crossed/tshape tables are allowed to be flipped since they visually look connected (usually) and theres no way you could realistically flip those.
|
You can try this adaption to deal with disallowing L or T shaped tables: |
|
Yeah i'll add it in, this should work |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
# About the pull request This PR revives #3740 and applies my suggested changes to that PR preventing T and cross shaped table flips. # Explain why it's good for the game Fixes a game ending exploit, and also gives a bit more sanity to table flipping. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Old testing: This cannot be flipped now:  But this can from the checkmark locations:  </details> # Changelog :cl: Drathek, Fira fix: Fixed an issue with table flips that could make some tables incorrectly unflippable, and cause infinite loops. It is no longer possible to flip tables that t-shape or cross, or spans more than 5 tiles away from you. /:cl: --------- Co-authored-by: Fira <[email protected]>
About the pull request
Infinite loop observed live.
This fixes three things with the table flipping:
loctable, meaning that the second part would essentially "follow turns" through already-flipped tables incorrectly. This is both incorrect and would cause the infinite loop.Testing Photographs and Procedure
Flipping 5 wide flat tables still works.
Changelog
🆑
fix: Fixed an issue with table flips that could make some tables incorrectly unflippable, and cause infinite loops. It is no longer possible to flip tables more than 8 long in either direction from flipping point.
/:cl: