Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yautja cloak changes #3757

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jun 28, 2023

About the pull request

Makes Yautja cloak permanent and cost no power. Also adds various multipliers for forced decloak source, resulting in differing durations it is unusable.

Explain why it's good for the game

Following discussions with Yautja Council and MorrowWolf, as referenced in #3261, Yautja overall are going to go through an overhaul to their dynamic and how they interact with the round, moving them more towards glass canons. The reason for permanent cloak however, is to prevent/reduce instances of Yautja players standing around in the open like football spectators as this detracts from their atmosphere.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Made Yautja cloak cost no power to operate, and created multipliers for disabled duration based upon what caused the Yautja to decloak.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 28, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justify this change

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 13, 2023
@realforest2001 realforest2001 added this to the Yautja Rework milestone Jul 13, 2023
@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Jul 13, 2023
code/__DEFINES/combat.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft July 19, 2023 05:27
@realforest2001 realforest2001 marked this pull request as ready for review July 19, 2023 13:15
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 20, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 20, 2023
@harryob harryob added this pull request to the merge queue Jul 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2023
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 49855f1 Jul 24, 2023
github-actions bot added a commit that referenced this pull request Jul 24, 2023
cm13-github added a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants