Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the speed for an embryo to burst a config + embryo buff #3844

Merged
merged 10 commits into from
Jul 19, 2023

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Jul 9, 2023

About the pull request

Changed it from a number to a config.
Changed larva_gestation_multiplier to 2, as it only processes once every 2 seconds, so it should increase the counter by 2 at a time.
Changed an else if to if as there could never be a situation where the stage was equal to 4 but not less than 5.

Explain why it's good for the game

Makes it easier to change, and keeps people guessing what stage they are at when hugged.

People were operating under the assumption that it was 7.5 minutes. However, due to process only running once every 2 seconds, it ended up taking twice as long.

Stage 4 was meant to make stasis slightly less effective, but due to a bug it just never happened.

Changelog

🆑
config: Moved time to burst to the config
balance: Fixed time to burst, lowering it from 15 minutes to 7.5 minutes by default
balance: Stasis bags used on late-stage mobs properly slow growth down less
/:cl:

@github-actions github-actions bot added the Config drag and drop label Jul 9, 2023
@BeagleGaming1 BeagleGaming1 changed the title Makes the chance for an embryo to burst a config Makes the speed for an embryo to burst a config Jul 9, 2023
@BeagleGaming1

This comment was marked as off-topic.

config/example/config.txt Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Embryo.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/Embryo.dm Outdated Show resolved Hide resolved
@ihatethisengine

This comment was marked as off-topic.

@BeagleGaming1 BeagleGaming1 marked this pull request as draft July 9, 2023 22:39
@BeagleGaming1
Copy link
Contributor Author

BeagleGaming1 commented Jul 9, 2023

I just noticed something strange with the embryo timer, gonna see if it can be fixed

@BeagleGaming1 BeagleGaming1 added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 9, 2023
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review July 9, 2023 23:30
@BeagleGaming1 BeagleGaming1 changed the title Makes the speed for an embryo to burst a config Makes the speed for an embryo to burst a config + embryo buff Jul 9, 2023
@morrowwolf
Copy link
Member

TM'ing because I'm paranoid

@morrowwolf morrowwolf added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 19, 2023
@morrowwolf
Copy link
Member

Seems fine let's goooooooooo

@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 61dcea5 Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
cm13-github added a commit that referenced this pull request Jul 19, 2023
@BeagleGaming1 BeagleGaming1 deleted the nesting branch September 15, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Config drag and drop Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants