-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the speed for an embryo to burst a config + embryo buff #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeagleGaming1
changed the title
Makes the chance for an embryo to burst a config
Makes the speed for an embryo to burst a config
Jul 9, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Zonespace27
requested changes
Jul 9, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
I just noticed something strange with the embryo timer, gonna see if it can be fixed |
BeagleGaming1
added
the
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
label
Jul 9, 2023
BeagleGaming1
changed the title
Makes the speed for an embryo to burst a config
Makes the speed for an embryo to burst a config + embryo buff
Jul 9, 2023
TM'ing because I'm paranoid |
morrowwolf
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Jul 19, 2023
Seems fine let's goooooooooo |
cm13-github
added a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Config
drag and drop
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Changed it from a number to a config.
Changed
larva_gestation_multiplier
to 2, as it only processes once every 2 seconds, so it should increase the counter by 2 at a time.Changed an
else if
toif
as there could never be a situation where the stage was equal to 4 but not less than 5.Explain why it's good for the game
Makes it easier to change, and keeps people guessing what stage they are at when hugged.
People were operating under the assumption that it was 7.5 minutes. However, due to
process
only running once every 2 seconds, it ended up taking twice as long.Stage 4 was meant to make stasis slightly less effective, but due to a bug it just never happened.
Changelog
🆑
config: Moved time to burst to the config
balance: Fixed time to burst, lowering it from 15 minutes to 7.5 minutes by default
balance: Stasis bags used on late-stage mobs properly slow growth down less
/:cl: