Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL Eggsac Carrier Changes - Sprites, Messages and Sounds #3868

Merged
merged 15 commits into from
Jul 24, 2023
Merged

QOL Eggsac Carrier Changes - Sprites, Messages and Sounds #3868

merged 15 commits into from
Jul 24, 2023

Conversation

MPhonks
Copy link
Contributor

@MPhonks MPhonks commented Jul 12, 2023

About the pull request

Adds new eggsac carrier sprites to the game. Includes eggsac overlay sprites that change based on how many eggs you carry. Implements a warning message for the hive when a carrier with eggs dies. Adds a sound effect to when an eggsac carrier dies. Fixes the egg drop chance upon death.

Huge thanks to ihatethisengine for helping me with the coding.

Explain why it's good for the game

Eggsac Carrier currently has no sprites, there's no differentiating one from a regular carrier.
This PR attempts to give more flavor to the strain. Also fixes something, so that's nice.

Testing Photographs and Procedure (Updated)

Screenshots & Videos

Sprites:
layers

Showcase Video:
https://github.com/cmss13-devs/cmss13/assets/134622054/e6f1f978-4ad7-41eb-8917-96440f8fd974

Changelog

🆑 MarpleJones, ihatethisengine2
add: Added new sprites for the Eggsac Carrier. Includes an additional death sound for the eggsac bursting.
add: Added a hive announcement for when a Carrier dies with eggs.
fix: Carrier egg drop chance upon death now works as intended.
/:cl:

Prepares eggsac_overlay with sprites.
@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jul 12, 2023
@MPhonks MPhonks marked this pull request as draft July 13, 2023 13:50
@MPhonks

This comment was marked as outdated.

@MPhonks MPhonks changed the title Adds new eggsac carrier sprites. QOL Eggsac Carrier Changes - Sprites, Messages and Sounds Jul 13, 2023
@MPhonks MPhonks marked this pull request as ready for review July 13, 2023 17:29
@MPhonks
Copy link
Contributor Author

MPhonks commented Jul 13, 2023

Changed it back to being an open PR. >:)
(Also, should probably be given a "fix" label...)

@harryob harryob added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 14, 2023
@MPhonks
Copy link
Contributor Author

MPhonks commented Jul 14, 2023

One last sprite change upcoming.

@MPhonks MPhonks requested a review from harryob July 14, 2023 19:17
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites are really nice, approved 👍

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jul 15, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 23, 2023
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit b9b353b Jul 24, 2023
27 checks passed
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 24, 2023
cm13-github added a commit that referenced this pull request Jul 24, 2023
@MPhonks MPhonks deleted the QOL-Eggsac-Carrier-Changes branch August 3, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants