-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL Eggsac Carrier Changes - Sprites, Messages and Sounds #3868
QOL Eggsac Carrier Changes - Sprites, Messages and Sounds #3868
Conversation
Prepares eggsac_overlay with sprites.
This comment was marked as outdated.
This comment was marked as outdated.
Need to fix eggsac_overlay randomizer.
…ks/cmss13 into QOL-Eggsac-Carrier-Changes
Added sound effect. Sprites appear in order. Thanks, ihatethisengine, for the coding help.
Changed it back to being an open PR. >:) |
Me and ihatethisengine big dumb dumb. Code adjustments.
Co-authored-by: harryob <[email protected]>
One last sprite change upcoming. |
Major sprite changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprites are really nice, approved 👍
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
About the pull request
Adds new eggsac carrier sprites to the game. Includes eggsac overlay sprites that change based on how many eggs you carry. Implements a warning message for the hive when a carrier with eggs dies. Adds a sound effect to when an eggsac carrier dies. Fixes the egg drop chance upon death.
Huge thanks to ihatethisengine for helping me with the coding.
Explain why it's good for the game
Eggsac Carrier currently has no sprites, there's no differentiating one from a regular carrier.
This PR attempts to give more flavor to the strain. Also fixes something, so that's nice.
Testing Photographs and Procedure (Updated)
Screenshots & Videos
Sprites:
Showcase Video:
https://github.com/cmss13-devs/cmss13/assets/134622054/e6f1f978-4ad7-41eb-8917-96440f8fd974
Changelog
🆑 MarpleJones, ihatethisengine2
add: Added new sprites for the Eggsac Carrier. Includes an additional death sound for the eggsac bursting.
add: Added a hive announcement for when a Carrier dies with eggs.
fix: Carrier egg drop chance upon death now works as intended.
/:cl: