AFK Facehuggers Convert to Normal Huggers #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an xeno take over time)
I was going to prevent facehuggers from being joinable, but maybe some people like it.
github-actions
bot
added
Feature
harryob
requested changes
Jul 14, 2023
Co-authored-by: harryob <[email protected]>
harryob
approved these changes
Jul 14, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 15, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
# About the pull request This PR is a followup to #3886 fixing dead huggers still converting to normal huggers when client-less. The assumption was that life wouldn't keep ticking when dead, but thats not the case. # Explain why it's good for the game Fixes #4486 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: Drathek fix: Fix dead huggers converting to non-player huggers /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR makes it so sentient huggers that have been AFK for 7 minutes, aren't aghosted, and have no client will convert to normal huggers (and subsequently die like normal unless they hug someone or get grabbed). I was considering removing facehuggers from the join as xeno list, but this way there's still a couple minutes they can be taken over before they convert.
Explain why it's good for the game
This can help cleanup the afk xeno list and possibly make a funny situation if a marine happens to be nearby when one converts.
Testing Photographs and Procedure
Screenshots & Videos
(Timer here was set to just 10 seconds for testing)
Changelog
🆑 Drathek
add: Facehuggers now convert to their NPC version after 7 minutes of inactivity and no client.
code: Cleanup join as xeno button code somewhat.
/:cl: