Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tent Tweaks & Fixes! #3918

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Tent Tweaks & Fixes! #3918

merged 5 commits into from
Jul 24, 2023

Conversation

ghostsheet
Copy link
Contributor

@ghostsheet ghostsheet commented Jul 18, 2023

About the pull request

Marines can destroy tents with an E-tool or shovel

Scattered the 4 tents to (the four corners) their own respective department with the big tent being in Bravo Bunks

You can no longer stand behind tent, (increases all tent height by 1)

Re-wrote xeno attacks on tents so it gives more feedback and is handled similarly to cades being attacked

Fixed bug where xenos can't slash the tent (or people in the tents) from the sides

Fixed bug where tent would possibly block bullets

Fixed bug where staying inside a tent that's being deleted will give your permanent see-through roof vision

Explain why it's good for the game

Tents were soft-griefing the marines by being poorly placed with no way to remove them.

This will allow marines to take down poorly placed tents
While pushing the responsibility of the tents onto the department that decides to take it down.

Big tent (RP tent) is in bravo bunks as it is an all access area where anyone can grab it, from bravo marines to CL or mess sergeant

The north walls of tents are now full density blocks no one should be able to enter or hide behind it (or hide traps/sentry items behind there)

Bug bad for the rest

Changelog

🆑 ghostsheet
add: Tents can be destroyed with an E-tool.
add: Tents are now in their respective department, Big tent is now in Bravo Bunks.
add: You can no longer stand behind a tent.
fix: Xenos can now slash tents from the side.
fix: Tents no longer randomly block bullets.
fix: Staying inside a tent when it is destroyed no longer give your permanent see-through roof vision.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 18, 2023
@ghostsheet ghostsheet changed the title Tent Fixes! Tent Tweaks & Fixes! Jul 18, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -1. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

code/modules/tents/blockers.dm Show resolved Hide resolved
code/modules/tents/deployed_tents.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 18, 2023 17:07
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jul 19, 2023
@ghostsheet ghostsheet marked this pull request as ready for review July 20, 2023 04:13
code/modules/tents/deployed_tents.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft July 20, 2023 08:31
@ghostsheet ghostsheet marked this pull request as ready for review July 20, 2023 08:55
code/modules/tents/deployed_tents.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 22, 2023 14:14
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall
do you not modify the actual tent map size?

code/modules/tents/deployed_tents.dm Show resolved Hide resolved
code/modules/tents/deployed_tents.dm Outdated Show resolved Hide resolved
code/modules/tents/deployed_tents.dm Show resolved Hide resolved
@ghostsheet ghostsheet marked this pull request as ready for review July 24, 2023 10:05
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 788da54 Jul 24, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-8). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 24, 2023
cm13-github added a commit that referenced this pull request Jul 24, 2023
@ghostsheet ghostsheet mentioned this pull request Jul 26, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 27, 2023
# About the pull request

Tent height was increased in #3918

Command and Medical tent height was increased
However Req and Big tent height was not increased.

This PR increases tent height for Req and Big tent

# Explain why it's good for the game

Whoops... forgot to change these vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants