Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hazard joe voicelines #3919

Closed
wants to merge 4 commits into from

Conversation

Mister-moon1
Copy link
Contributor

@Mister-moon1 Mister-moon1 commented Jul 18, 2023

About the pull request

Finally the hazard joe will have its own voice lines along with some minor changes, since they were added it was planned for them to be more durable and maybe get the voice lines from alien isolation. This PR is here to do this by increasing the HP by a small 25 and a minor increase to burns at the cost of a bit of speed along with porting around 43 unique hazard joe voice lines.

Explain why it's good for the game

Adds soul by making hazard joes more realistic, they were supposed to be dealing with cores and reactors as opposed to the standard maintenance that of a normal working joe along with giving them lore accurate voices.

Testing Photographs and Procedure

https://streamable.com/hze2y8

Changelog

🆑
soundadd: added new voice lines for the hazard varient of the working joe
balance: minor changes regarding hazard joe durability and speed
code: made hazard joe its own species for ease of editing
/:cl:

@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Jul 18, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you went about this is, in my eyes, fundamentally wrong.

Ideally, you should be adding a 2nd variable to WJ emote datums with the hazard joe variant sounds, and overriding the base WJ emote datum's get_sound() to use the alternate voiceline if the person is a hazard joe

@harryob harryob marked this pull request as draft July 18, 2023 17:03
@Mister-moon1
Copy link
Contributor Author

along with issues with VSC telling me that it cannot find a file which i did not ask it to every time i try to do something and other issues getting code to work i will be closing this, if anyone wishes to try and do this you may DM me for the sound files

@Mister-moon1
Copy link
Contributor Author

mrmoon8844 is my discord

@harryob harryob mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Sound Blast 5 minutes of bass boosted music to our players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants