-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faction Access & Almayer Security Overhaul #4035
Merged
morrowwolf
merged 27 commits into
cmss13-devs:master
from
realforest2001:project/factionaccess
Aug 22, 2023
Merged
Faction Access & Almayer Security Overhaul #4035
morrowwolf
merged 27 commits into
cmss13-devs:master
from
realforest2001:project/factionaccess
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
Code Improvement
Make the code longer
Feature
Feature coder badge
Removal
snap
labels
Jul 28, 2023
Nanu308
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapping lgtm, just changes to req_access
realforest2001
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Jul 29, 2023
3 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
3 tasks
3 tasks
3 tasks
Closed
3 tasks
cm13-github
added a commit
that referenced
this pull request
Aug 22, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
# About the pull request Followup to #4035. # Explain why it's good for the game Is fix. # Changelog :cl: fix: CL's lockbox can be properly opened once again. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Feature
Feature coder badge
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Removal
snap
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Removes the majority of accesses from non marine characters. No more free walking into CIC for the CLF, you're gonna have to work for it.
Creates faction specific accesses for basic things, these are not assigned to anything at the moment.
Overhauled how we get accesses so it no longer uses a bazillion different procs and instead relies on a centralised proc and defines.
Added specific access lists for WY Goons, PMCs, Liaison and Survivor Liaison as they're tailored to their uses.
Added very generic CLF and UPP lists, all UPP personnel have all their accesses FOR NOW.
Added a mapping var (access_changed) for identifying doors/objects that have non-standard access tags to allow for easier locating of things that need updates should access numbers be changed.
Explain why it's good for the game
Right now we use a million different procs to get accesses. This is really confusing and makes it difficult to tell who's getting what as it's spread out all over the place.
As for why I'm changing ERT accesses, this is something discussed with Morrow and Nanu, it doesn't make a whole lot of sense for your average CLF plebian to be able to walk through all security measures on a military ship like they don't exist. Instead, they'll now get at most the generic Emergency Response codes to open specific areas of the ship key to responders - Medbay and Maintenance.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
code: Overhauled how ID accesses are assigned via proc, compiling all the many different procs we used into one.
add: Added faction specific accesses to all major factions.
del: Removed almost all marine accesses from non marine presets. No more free CIC access to CLF.
code: Removed duplicate code in the VAI file.
add: Adds a mapping var to indicate a door has non-standard access tags. This is to make it significantly easier for any future access changes to know if they need to look somewhere.
maptweak: Applied this var to every door I could find on the Almayer that has non-standard access. Colonies and other stuff to come in a future update.
add: Added various new accesses to colonial doors, added WY_SECURITY and WY_RESEARCH to marine research doors.
maptweak: Added reinforced piping to lifeboats area. Didn't make much sense for a cruicial part of the evacuation procedures to be prone to spontaneous explosions that can singlehandedly end a marine evacuation without hostiles ever seeing it.
maptweak: Added reinforced piping to the research closed loop (it's a closed loop). Also removed CIC access from containment shutters as CIC access can't open the doors.
maptweak: Changed a couple walls around research from standard to reinforced, to fit with the containment breach shutters.
/:cl: