Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed UPP Survivors Insert Tweaks #4123

Merged
merged 11 commits into from
Aug 30, 2023

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Aug 6, 2023

About the pull request

Changes based on feedback and personal observations

Major changes

  • A second map insert has been added that is guaranteed to occur whenever UPP survivors spawn. A second, destroyed, UPP dropship containing supplies (10 standard t-71 mags, 4 AP mags, a bunch of grenades). Including a single UPP PKP Machinegun. Only the Specialist and SL can use it. (I'd say its balanced because the weapon has horrible accuracy and will likely cause FF in unskilled hands).
  • UPP SL spawns with a guaranteed set of armour and their beret instead of a officer's jacket. Feels more thematic and the officer's jacket is meant for high ranking officers and not SLs.
  • Reduced spawns so there is only 1 Medic and 1 Engineer spawn, but they are both now a higher priority to spawn. Spawns should now go SL > Spec > Engi / Medic > Soldiers.
  • SL and Spec now have driving skills.
  • Added a lore entry when the survs spawn to give survs a hint to go explore to find the other crashed ship.

Minor Changes

  • Decreased chance of a UPP spawning with a Pulse Carbine slightly, due to how weak it is. Now 1/5 chance instead of 1/3.
  • Adds some buckshot ammo to the crashed dropship due to low ammo amount given to UPP who spawn with shotgun. UPP Shotgun feels balanced since it has high upfront damage but a low RoF. However low ammo meant a lot of people were ditching them for survivor shotguns.
  • SL has UPP spec weapon training (in case a synth takes the Spec spawn, so at least 1 person can use the minigun)
  • UPP now have access to the UPP comms channel.
  • HUD icons are now in place.

Explain why it's good for the game

The Medic/Engi changes ensure there is a guarantee of a single Medic and Engineer outside of very lowpop. I was noticing the prior spawn system means you'll see a lot of Medics but rarely a Engineer. This change should also mean more people will spawn as Soldiers instead of 90% of the squad being Medics and Engineers.

The supply cache is to give the UPP a alternative objective, instead of rushing to the meta hold spots they can try to make a run for a supply cache to give them a better chance of survival.

Considering my observation of as many UPP surv rounds as I can, I've found its almost guaranteed the UPP are overrun by the time the USCM arrive. Perhaps a chance at some extra ammo might tip the scales?

Everything else is self explanatory.

Testing Photographs and Procedure

Screenshots & Videos

Screenshot 2023-08-15 00 20 09

Screenshot 2023-08-15 01 41 24

Changelog

🆑
balance: Large amount of balance changes to UPP survivors on Trijent. New spawn setup guarantee's you'll get 1 Medic and 1 Engineer.
balance: UPP survivors now have access to HUD icons for squad roles, and access to the UPP communications channel if the colony communications is repaired.
balance: UPP surv SL's and Specialists can now drive vehicles.
balance: A second, crashed, UPP dropship can be found somewhere on Trijent if the UPP survivors spawn. It contains extra supplies and stronger firearms. But requires a detour to find.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Aug 6, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 14, 2023
@Steelpoint
Copy link
Contributor Author

Ok, I think we're good.

@Steelpoint Steelpoint marked this pull request as ready for review August 14, 2023 18:26
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Aug 15, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 22, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get a mapper to sign off and i'll merge

code/game/objects/items/devices/radio/headset.dm Outdated Show resolved Hide resolved
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 25, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 28, 2023
@Steelpoint
Copy link
Contributor Author

I've changed the minigun to the new PKP Machinegun.

Functionally its roughly similar to the minigun and it retains the spec only lock, so only the UPP SL or Spec can use it, so Marines can't steal it.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good let's gooo!

@morrowwolf morrowwolf added this pull request to the merge queue Aug 30, 2023
Merged via the queue into cmss13-devs:master with commit bf648db Aug 30, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 30, 2023
@Steelpoint Steelpoint deleted the UPPSurvBalanceOne branch July 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping did you remember to save in tgm format? Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants