Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerfs to defibrillators, changes to heart damage & bloodloss #4137

Merged
merged 17 commits into from
Aug 11, 2023

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Aug 8, 2023

About the pull request

Changes heart damage from three conditions to more of a smooth slider
Makes successful defibs guaranteed to deal heart damage, with a range of damage

Explain why it's good for the game

Makes death more punishing while also meaning a minor amount of heart damage is less important

Testing Photographs and Procedure

Screenshots & Videos

I really didn't test this

Changelog

🆑
balance: Defibrillators are guaranteed to deal heart damage on successful revives
balance: Blood volume now scales with heart damage rather than being a hardcoded multiplier
balance: Blood volume oxyloss now scales rather than being a hardcoded loss amount
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 8, 2023
@Zonespace27 Zonespace27 marked this pull request as draft August 8, 2023 04:26
code/modules/mob/living/blood.dm Outdated Show resolved Hide resolved
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also let's change the oxyloss to be a percentage of lost blood (past the safe point) as well. It's a bit lower down.

Copy link
Contributor

@zzzmike zzzmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

code/game/objects/items/devices/defibrillator.dm Outdated Show resolved Hide resolved
@Segrain Segrain self-requested a review August 8, 2023 11:05
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review August 9, 2023 06:22
@BeagleGaming1 BeagleGaming1 changed the title Nerfs to defibrillators and changes to heart damage Nerfs to defibrillators, changes to heart damage & bloodloss Aug 9, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Aug 11, 2023
Merged via the queue into cmss13-devs:master with commit 589a1a6 Aug 11, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 11, 2023
@BeagleGaming1 BeagleGaming1 deleted the heart-nerf branch September 15, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants