Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Provost radio & radio channel #4160

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Aug 11, 2023

About the pull request

Gives Provost their own radio channel. Didn't make much sense to me the amount of people who have High Command radios and access to all that entails. This splits off all the Non-Marshal (General) level provost to their own radio.

Also removes ignore_z from High Command radios because it prevents marines being able to hear what is said on their channels by a radio with ignore_z.

Explain why it's good for the game

A bit of depth, and to differentiate from High Command and Provost explicit.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a Provost radio & channel.
qol: Changed High Command radio to have most channels off by default.
del: Removed ignore_z from High Command radios.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. UI deletes nanoui/html Feature Feature coder badge Removal snap labels Aug 11, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 19, 2023
@harryob harryob added this pull request to the merge queue Sep 1, 2023
Merged via the queue into cmss13-devs:master with commit a767d44 Sep 1, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Removal snap Sprites Remove the soul from the game. Stale beg a maintainer to review your PR UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants