Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project ARES: Admin Console #4182

Merged
merged 71 commits into from
Mar 7, 2024
Merged

Project ARES: Admin Console #4182

merged 71 commits into from
Mar 7, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Aug 13, 2023 •
edited
Loading

About the pull request

Adds a remote access console for Admins to see what the ARES Interface contains. Also allows for direct response to 1:1 messages.

Explain why it's good for the game

Makes things much easier for staff when dealing with anything related to the ARES Interface.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
admin: Adds a remote admin ARES Interface so staff can see the interface remotely.
admin: Staff can now approve and revoke ARES Access tickets via remote interface if there are no Working Joes.
/:cl:

@realforest2001 realforest2001 added the Admin Make things harder for admins label Aug 13, 2023
@realforest2001 realforest2001 added this to the Project ARES milestone Aug 13, 2023
@github-actions github-actions bot added the UI deletes nanoui/html label Aug 13, 2023
@gitbirb gitbirb mentioned this pull request Aug 14, 2023
Closed
3 tasks
Drulikar
Drulikar requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still more to review, but I have reviewed at least the problems with the ui_act

code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft February 14, 2024 19:45
@realforest2001 realforest2001 marked this pull request as ready for review February 21, 2024 10:15
harryob
harryob previously requested changes Feb 22, 2024
View reviewed changes
code/game/machinery/ARES/ARES_procs.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_records.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft February 22, 2024 16:15
@realforest2001 realforest2001 marked this pull request as ready for review February 26, 2024 16:54
Drulikar
Drulikar requested changes Mar 3, 2024
View reviewed changes
code/game/machinery/ARES/ARES_procs.dm Show resolved Hide resolved
code/game/machinery/ARES/ARES_procs.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
code/game/machinery/ARES/ARES_interface_admin.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft March 3, 2024 13:39
@Drulikar Drulikar marked this pull request as ready for review March 4, 2024 10:41
@Drulikar Drulikar added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Mar 6, 2024

CI requires fixes from #5891

@Drulikar Drulikar added this pull request to the merge queue Mar 7, 2024
Merged via the queue into cmss13-devs:master with commit 7f60873 Mar 7, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Mar 7, 2024
@cm13-github
Automatic changelog for PR #4182 [ci skip]
211d5aa
@realforest2001 realforest2001 deleted the project/ares/admin_console branch March 29, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Segrain Segrain Segrain left review comments

@morrowwolf morrowwolf morrowwolf requested changes

@Drulikar Drulikar Drulikar approved these changes

@harryob harryob Awaiting requested review from harryob

Assignees
No one assigned
Labels
Admin Make things harder for admins Stale Exempt PR can't go stale UI deletes nanoui/html
Projects
None yet
Milestone
Project ARES
Development

Successfully merging this pull request may close these issues.
6 participants
@realforest2001 @cm13-github @Drulikar @Segrain @morrowwolf @harryob