Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove and exploit that allow someone to take multiple sample from a plant and increasing it's growths. #4187

Closed

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Aug 15, 2023

About the pull request

this doesn't indirectly fix the issue or make it non relevant

since previously you could use the randomness of the code to growth a plant i decided to just reduce it to a one time.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: remove and exploit that allow someone to take multiple sample from a plant and increasing it's growths.
/:cl:

a plant and remove randomness of the damage
done to plant .
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 15, 2023
@Weuyn
Copy link
Contributor

Weuyn commented Aug 15, 2023

removing the multi sampling is really sucky!

@Huffie56 Huffie56 marked this pull request as ready for review August 15, 2023 20:50
@Huffie56 Huffie56 changed the title fix remove the ability to do multiple sample with the rng element and remove rng to it reducing health of the plant. fix remove and exploit that allow someone to take multiple sample from a plant and increasing it's growths. Aug 15, 2023
@@ -532,10 +532,8 @@

// Create a sample.
seed.harvest(user,yield_mod,1)
plant_health -= (rand(3,5)*10)

if(prob(30))
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an exploit that you can harvest a plant multiple times, the issue is that it supposedly increases the stage, and just removing the mechanic entirely in an attempt to remove the bug is not the way to do that

Copy link
Contributor Author

@Huffie56 Huffie56 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't manage to understand why the stage was increasing so that's the solution i came up with to avoid people being able to growth the plant using a bug......
code is very weird and not straight forward at all.

@Huffie56 Huffie56 marked this pull request as draft August 16, 2023 07:48
@Huffie56
Copy link
Contributor Author

this part of the code is weird and it would be probably better to start fresh and port another server code at this point...

@Huffie56
Copy link
Contributor Author

no idea how to solve this issue then.... code is just not understandable for me in hydroponic.....

@Huffie56 Huffie56 closed this Aug 18, 2023
@Huffie56 Huffie56 deleted the fix_hydrotraytakingsample branch August 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants