Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove and exploit that allow someone to take multiple sample from a plant and increasing it's growths. #4187

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions code/modules/hydroponics/hydro_tray.dm
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,8 @@

// Create a sample.
seed.harvest(user,yield_mod,1)
plant_health -= (rand(3,5)*10)

if(prob(30))
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an exploit that you can harvest a plant multiple times, the issue is that it supposedly increases the stage, and just removing the mechanic entirely in an attempt to remove the bug is not the way to do that

Copy link
Contributor Author

@Huffie56 Huffie56 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't manage to understand why the stage was increasing so that's the solution i came up with to avoid people being able to growth the plant using a bug......
code is very weird and not straight forward at all.

sampled = 1
plant_health -= 30
sampled = 1

// Bookkeeping.
check_level_sanity()
Expand Down
Loading