Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New research biosuits #4223

Closed
wants to merge 0 commits into from
Closed

Conversation

SubjectD9341
Copy link
Contributor

@SubjectD9341 SubjectD9341 commented Aug 21, 2023

About the pull request

This updates the old goofy bio suit sprites to new updated ones

Explain why it's good for the game

New prettier sprites good. Also makes so that admins won't be forced to use the goofy biosuit for zombie events (the famous green frogmen event)

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 SubjectD9341
imageadd: added the icons for the new biosuits
imagedel: removed the icons for the old biosuits
/:cl:

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Aug 21, 2023
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome sprites but there are a few things that need to be changed to push them into the "Mergeable AF" section.

first the palette; some of the colors are borrowed from the legacy sprite but then others are borrowed from more up-to-standard sprites which turns it into a hard to manage mess. i recommend finding a more up-to-date sprite reference close to what you want to make and sticking with that for pulling colors, or at the very least keep it to a group of current-standard sprites.

next is the hood/mask and webbings. cut off the two corner pixels on the top of his head to smooth out the hood shape
image

on the north-face sprite, the hood needs a redraw to look less like a face. maybe something closer to this concept art sheet
image

for the webbing, if it's going to be integrated in the suit item it should be more subtle in the overall sprite. look at the recent resprite for snake silva's donor suit. it's a great reference for what you're trying to do regarding the webbing and belts around the upper thighs. also the bio_general hood is too far to the right/left on the east/west sprite and gives the researcher gamer neck (not good)

i made some quick examples of what i'm looking for based off my suggestions to help show what i mean with the palette ripping and other things. (fixing up the shading and outline with a cleaner palette and adjusting the webbing, to be more specific)
image

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 9, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2023
# About the pull request
I accidentally closed the other PR when updating the sprites after
feedback, old PR: #4223

This updates the old goofy bio suit sprites to new updated ones, tested
in game to ensure no issues.

# Explain why it's good for the game

New prettier sprites good. Also makes so that admins won't be forced to
use the goofy biosuit for zombie events (the famous green frogmen
event). Now they come with updated color palette to reflect more CM's
artstyle

# Testing Photographs and Procedure





</details>

![Screenshot 2023-09-19
215939](https://github.com/cmss13-devs/cmss13/assets/115213778/f005408c-f836-4a5e-ab6a-d819722a6243)

![Screenshot 2023-09-19
215949](https://github.com/cmss13-devs/cmss13/assets/115213778/28288569-bc8a-4a3e-90e0-1971735db6a6)


![image](https://github.com/cmss13-devs/cmss13/assets/115213778/ad802dfc-aaa2-40f0-bd0a-56d3d003c891)





# Changelog
:cl:
imageadd: added the icons for the new biosuits
imagedel: removed the icons for the old biosuits
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants