Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : clean dmi file extract spritten hiden inside other sprites direction. removing sprite change from dmm files. #4232

Merged
merged 31 commits into from
Aug 31, 2023
Merged

refactor : clean dmi file extract spritten hiden inside other sprites direction. removing sprite change from dmm files. #4232

merged 31 commits into from
Aug 31, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Aug 22, 2023 •
edited by github-actions bot
Loading

About the pull request

clean dmi file extract sprite hidden inside other sprites direction. removing sprite change from dmm files.

Explain why it's good for the game

it's good for mappers and our common sanity.
sprite shouldn't be hidden into sprite and sprite shouldn't be change in DMM files....

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: clean dmi file extract sprite hidden inside other sprites direction. removing sprite change from dmm files.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Refactor Make the code harder to read labels Aug 22, 2023
Drulikar
Drulikar previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions and repeat. It's not that it was missing new lines, it's that when you use ; that indicates there is supposed to be another var edit on the following line.

maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
maps/map_files/FOP_v3_Sciannex/Fiorina_SciAnnex.dmm Outdated Show resolved Hide resolved
@Huffie56
Copy link
Contributor Author

i saw in mapbot that i made an oupsy
will fix it later...

@Huffie56
Copy link
Contributor Author

i remove all the icon-state for floors for fiorina their is like 600 random icon state to handle for the map....

@Huffie56 Huffie56 marked this pull request as ready for review August 24, 2023 08:30
@Huffie56 Huffie56 requested a review from Drulikar August 25, 2023 20:28
@Drulikar Drulikar removed their request for review August 26, 2023 12:39
@Drulikar
Copy link
Contributor

Sprites and mapping aren't generally things I can approve/merge but there is nothing obviously wrong with the changes at the moment.

@Drulikar Drulikar requested a review from a team August 26, 2023 12:40
@Huffie56
Copy link
Contributor Author

thanks anyway for checking it...

harryob
harryob approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bless you

@harryob harryob added this pull request to the merge queue Aug 31, 2023
@Huffie56
Copy link
Contributor Author

bless you

this is a pain to do won't do this every month....

Merged via the queue into cmss13-devs:master with commit b67fb9b Aug 31, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 31, 2023
@cm13-github
Automatic changelog for PR #4232 [ci skip]
f6976fb
@Huffie56 Huffie56 deleted the clean_dm_dmi_files_fiorina_and_outoofrotationmap branch August 31, 2023 21:12
@Huffie56 Huffie56 restored the clean_dm_dmi_files_fiorina_and_outoofrotationmap branch September 3, 2023 15:17
morrowwolf added a commit that referenced this pull request Sep 4, 2023
@morrowwolf
Revert "refactor : clean dmi file extract spritten hiden inside other…
380ef5b 
… sprites direction. removing sprite change from dmm files. (#4232)"

This reverts commit b67fb9b.
@morrowwolf morrowwolf mentioned this pull request Sep 4, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2023
@morrowwolf
Revert "refactor : clean dmi file extract spritten hiden inside other…
8625443 
… sprites direction. removing sprite change from dmm files." (#4332)

Reverts #4232

Revert for TM until re-cleaned up. Huge gaps in Fiorina and other maps.
Needs another pass.
@Huffie56 Huffie56 deleted the clean_dm_dmi_files_fiorina_and_outoofrotationmap branch September 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Nanu308 requested changes

@harryob harryob harryob approved these changes

@Drulikar Drulikar Drulikar left review comments

Assignees
No one assigned
Labels
Mapping did you remember to save in tgm format? Refactor Make the code harder to read Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Huffie56 @Drulikar @harryob @Nanu308