Biolock & Tristan Donor Gear #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What an absolute king. I had both Forest and Frozen give this change the okay ^-^ |
Drulikar
requested changes
Aug 24, 2023
|
Fixed. |
Drulikar
approved these changes
Aug 25, 2023
|
Warfan is a god, big dubs! |
sleepynecrons
suggested changes
Aug 30, 2023
There was a problem hiding this comment.
the shading on biolock's armor is fine, but the highlights on tristan's gear need some minor work with the darker color scheme.
made an example of what it should be closer to
if you'd rather just use my edit you can copy these images below into whatever software you're using to sprite
also, for biolock's helmet - "There is a built-in camera on the right side." but that isn't represented on the current sprite what's up with that. would be cool to see and make it more unique than a simple recolor
|
@sleepynecrons fixed |
sleepynecrons
approved these changes
Sep 9, 2023
cm13-github
added a commit
that referenced
this pull request
Sep 9, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
# About the pull request This PR fixes an issue caused by a path remapping in #4245 where a typecheck for an old fluff value no longer triggered to prevent map specific camos on the fluff gear. Note: NO_SNOW_TYPE is more than just snow, but also not all item types even perform a test on that flag to prevent calling select_gamemode_skin. # Explain why it's good for the game Fixes #4398 (Or any /obj/item/clothing/suit/storage/marine/light/fluff) # Changelog :cl: Drathek fix: Fix some donor items breaking on maps with camos. fix: Fix donor items not having a fingerprint atom flag and donor armors not having conductive atom flag. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
A change to Biolock's donor gear (credit to Amory for the sprite)
&
A change to Tristan's donor gear
Changes to legacy donor gear is allowed (to the best of my knowledge)
PR made on behalf of Biolock & Tristan.
Explain why it's good for the game
Donor gear is good
Testing Photographs and Procedure
https://cdn.discordapp.com/attachments/1144067901343666216/1144090409501474916/image.png
Changelog
🆑
add: Changes donor Biolock's medium medic armour to a light custom paintjob armour and donor Tristan's reactive scientist armour to a custom marine armour