Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesser drone changes #4280

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Aug 28, 2023

About the pull request

This PR:

Allows lesser drones to spawn at pylons and core.

Creates a pool of lesser drones at cores and pylons that regenerate over time. It takes about 10 seconds to get one more when queen is on ovi and about 120 seconds when queen is off.

Lesser drones and facehuggers no longer count towards the lesser drone count but lesser drones are still capped at 1/3rd of the hive with a minimum of 3.

Facehuggers have also been changed to not count lesser drones and themselves for max calculations.

Explain why it's good for the game

While fun, the infinite and immediate respawn of lesser drones from hive core while queen is on ovi is a bit much. This should help with this problem while also keeping lesser drones as free and horde-like components of the xeno force.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
add: Allowed lesser drones to spawn at pylons and core.
add: Created a pool of lesser drones at cores and pylons that regenerate over time. It takes about 10 seconds to get one more when queen is on ovi and about 120 seconds when queen is off.
balance: Lesser drones and facehuggers no longer count towards the lesser drone count but lesser drones are still capped at 1/3rd of the hive with a minimum of 3.
balance: Facehuggers have also been changed to not count lesser drones and themselves for max calculations.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Aug 28, 2023
@morrowwolf morrowwolf added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 28, 2023
code/game/gamemodes/cm_initialize.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/structures/special/pylon_core.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/xeno_defines.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/xeno_defines.dm Outdated Show resolved Hide resolved
code/game/gamemodes/cm_initialize.dm Outdated Show resolved Hide resolved
code/game/gamemodes/cm_initialize.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 29, 2023 09:22
@morrowwolf morrowwolf marked this pull request as ready for review August 29, 2023 11:19
@morrowwolf
Copy link
Member Author

TM'ing in case I broke something

cm13-github
cm13-github previously approved these changes Aug 30, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better

@harryob harryob enabled auto-merge August 30, 2023 20:32
@harryob harryob added this pull request to the merge queue Aug 30, 2023
Merged via the queue into cmss13-devs:master with commit 9e36325 Aug 30, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 30, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
…6510)

# About the pull request

This PR is a follow up to #4280 where it failed to make any check on the
user examining the core.

# Explain why it's good for the game

Fixes #6509 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/029ae013-16be-4d35-8c86-6cd027b1fca3)

</details>


# Changelog
:cl: Drathek
fix: Fixed the core showing lesser drone counts to humans when examined
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants