-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesser drone changes #4280
Merged
Merged
Lesser drone changes #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrowwolf
added
the
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
label
Aug 28, 2023
harryob
requested changes
Aug 29, 2023
TM'ing in case I broke something |
3 tasks
Drulikar
reviewed
Aug 30, 2023
This was referenced Aug 30, 2023
cm13-github
previously approved these changes
Aug 30, 2023
harryob
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better
cm13-github
added a commit
that referenced
this pull request
Aug 30, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
…6510) # About the pull request This PR is a follow up to #4280 where it failed to make any check on the user examining the core. # Explain why it's good for the game Fixes #6509 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ![image](https://github.com/cmss13-devs/cmss13/assets/76988376/029ae013-16be-4d35-8c86-6cd027b1fca3) </details> # Changelog :cl: Drathek fix: Fixed the core showing lesser drone counts to humans when examined /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR:
Allows lesser drones to spawn at pylons and core.
Creates a pool of lesser drones at cores and pylons that regenerate over time. It takes about 10 seconds to get one more when queen is on ovi and about 120 seconds when queen is off.
Lesser drones and facehuggers no longer count towards the lesser drone count but lesser drones are still capped at 1/3rd of the hive with a minimum of 3.
Facehuggers have also been changed to not count lesser drones and themselves for max calculations.
Explain why it's good for the game
While fun, the infinite and immediate respawn of lesser drones from hive core while queen is on ovi is a bit much. This should help with this problem while also keeping lesser drones as free and horde-like components of the xeno force.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Morrow
add: Allowed lesser drones to spawn at pylons and core.
add: Created a pool of lesser drones at cores and pylons that regenerate over time. It takes about 10 seconds to get one more when queen is on ovi and about 120 seconds when queen is off.
balance: Lesser drones and facehuggers no longer count towards the lesser drone count but lesser drones are still capped at 1/3rd of the hive with a minimum of 3.
balance: Facehuggers have also been changed to not count lesser drones and themselves for max calculations.
/:cl: