Gives the M56D full auto #4336
Merged
Gives the M56D full auto #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
harryob
approved these changes
Sep 11, 2023
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
added a commit
that referenced
this pull request
Sep 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
# About the pull request Fixes a bug with m56d on burst-fire and single-fire mode which allows it to fire with no delay due to #4336 <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Game-breaking and actively abused # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Fixes no fire delay on m56d in semi-auto and burst fire /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Gives the m56d full auto. Refactors a lot of m56d/m2c code to make this possible. Test merge first.
Also gives the m56d an ammo counter on-firing. Does not apply to the M2C.
Explain why it's good for the game
This was planned for #4003, but was too far out of scope to be done in that PR. Automatic mode is better from a user QOL standpoint, and shouldn't affect balance much.
Testing Photographs and Procedure
Screenshots & Videos
Works
Changelog
🆑
balance: M56D now has full auto mode.
qol: M56D now has an ammo counter when firing.
del: M2C can no longer rotate with MMB
/:cl: