Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE Tidy-up #4367

Merged
merged 1 commit into from
Sep 11, 2023
Merged

TWE Tidy-up #4367

merged 1 commit into from
Sep 11, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Sep 9, 2023

About the pull request

Tidies up the TWE RMC Presets as they were a little scattered.

  • Moves all the entries in the presets to be grouped properly, no more WEAR_HEAD appearing at the bottom of the list between the contents of droppouches.
  • Removed surgical line as it was being duplicated from the surgical kit.
  • Added MRE to the MRE carrier as it was otherwise using custom backpack and identical contents.
  • Amends skills so Breacher and Pointman are no longer able to use smartguns.

Explain why it's good for the game

A little bit more efficient and easier to handle.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Tidied up the TWE presets so they're easier to read.
del: Removed duplicate surgical line from all TWE presets.
add: Added an MRE box to the TWE MRE carrier preset.
spellcheck: Added unique names to the RMC armors.
fix: Fixed iconstate names being backwards for TWE pointman and SG.
code: Removed unnecessary repeated values for TWE armors.
code: Tidied the RMC skillsets to be consistent in ordering of skills.
add: Added an SG specific skillset for RMCs.
fix: Fixed duplicate entry for medical training on RMC TL skillset.
spellcheck: Renamed default RMC skillset to Royal Marines Commando rather than Royal Marines Commando Rifleman.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Code Improvement Make the code longer Removal snap Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Fix Fix one bug, make ten more labels Sep 9, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites be fine 🆗

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Sep 9, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@harryob harryob added this pull request to the merge queue Sep 11, 2023
Merged via the queue into cmss13-devs:master with commit 3e0755b Sep 11, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Removal snap Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants