-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Joe Announcement Removal #4373
Merged
harryob
merged 1 commit into
cmss13-devs:master
from
morrowwolf:working-joe-announcement-removal
Sep 11, 2023
Merged
Working Joe Announcement Removal #4373
harryob
merged 1 commit into
cmss13-devs:master
from
morrowwolf:working-joe-announcement-removal
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Sep 9, 2023
Zonespace27
reviewed
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps an APOLLO link message instead?
@@ -46,11 +46,6 @@ | |||
else | |||
. = {"You are a <a href='"+URL_WIKI_WJ_GUIDE+"'>Working Joe</a> for Hazardous Environments! You are held to a higher standard and are required to obey not only the Server Rules but Marine Law, Roleplay Expectations and Synthetic Rules. You are a variant of the Working Joe built for tougher environments and fulfill the specific duty of dangerous repairs or maintenance. Your primary task is to maintain the reactor, SMES and AI Core. Your secondary task is to respond to hazardous environments, such as an atmospheric breach or biohazard spill, and assist with repairs when ordered to by either an AI Mainframe, or a Commisioned Officer. You should not be seen outside of emergencies besides in Engineering and the AI Core! Stay in character at all times. Use the APOLLO link to communicate with your uplink!"} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/datum/job/civilian/working_joe/announce_entry_message(mob/living/carbon/human/H) | |
addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(ares_apollo_talk), "[H.real_name] has been activated."), 1.5 SECONDS) | |
return ..() | |
cm13-github
added a commit
that referenced
this pull request
Sep 11, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
# About the pull request Followup from #4373, Working Joe spawn announced via APOLLO # Explain why it's good for the game While it is true that we don't really need a shipwide announcement for WJs, there are many good reasons to have it at least be on APOLLO instead (logged, other WJs know, etc), also this was requested from other PR. # Changelog :cl: add: Working Joe arrivals announced in Apollo link /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Removes the shipside announcement for working joes joining.
Explain why it's good for the game
Frankly, Working Joes aren't nearly important enough to have a message about them joining the round. They should be quiet and (vaguely) efficient in their tasks.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Morrow
del: Removed the shipside announcement for working joes joining
/:cl: