Cloaked mobs don't give off visible messages (+cloak logic refactor) #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
Zonespace27
added
the
Needs Testing
realforest2001
requested changes
Sep 14, 2023
|
Can you add the cloak trait to the changelog/title as it's the main part of this PR |
Co-authored-by: forest2001 <[email protected]>
Zonespace27
changed the title
Added to title; changelog isn't needed due to it not being player-facing |
3 tasks
morrowwolf
added
the
Balance Approved
harryob
requested changes
Sep 15, 2023
3 tasks
3 tasks
harryob
approved these changes
Sep 24, 2023
cm13-github
added a commit
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Pretty much the title. Visible messages (visible_message proc) don't give off messages to others if the origin is cloaked.
I'm a bit leery of doing this on
visible_messageso this is gonna need testing first.Makes checking for cloaking better, adding a trait on cloak instead of checking for user alpha
Explain why it's good for the game
Being able to see things like "Unknown peers through the laser designator" while they're invisible is a pretty large tell despite you not having seen them.
Testing Photographs and Procedure
Screenshots & Videos
Works
Changelog
🆑
balance: Cloaked mobs no longer give off visible messages
/:cl: