Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Dropship Pilot Two Dropship Crew Chief hours, instead of Five Marine squad hours. #4488

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Conversation

HumiliatedGoblin
Copy link
Contributor

@HumiliatedGoblin HumiliatedGoblin commented Sep 24, 2023

About the pull request

Changes the hours from five marine hours to two DCC hours, something that should've been done years ago.

Explain why it's good for the game

I'm SICK and TIRED of TROGLADYTE dropship pilots who don't even ATTEMPT to read the guide, and think they're the coolest person ever after direct firing without a laser detector, wiping the front with six minis, and they don't even have the GAL
to apologize afterwards. I want this to END.

It's honestly comical how terrible pilots have gotten, so much so that I refuse to call them in unless they have a silver medal or above. It makes absolutely no sense how pilots only need five hours as a marine to have the power to kill fifteen marines with one napalm. By making it two DCC hours, you give them a chance to learn how to fly, and also get tips from experienced pilots.

I honestly believe that the reason marine winrate is so low is because of the sheer incompetence shown by command slots and fire support-ists, and by making the hours needed higher, HOPEFULLY marines can actually use fire support without fear of the person faltering and killing everyone.

I was thinking of having Two Fireteam Leader hours as well, but because of the moving away of RTO's, I didn't think it was necessary and would've been overkill. Might be something to consider though.

was brought upon by this screenshot:
https://media.discordapp.net/attachments/604397850675380234/1155395437256249354/image_4.png

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 bostonthebear
add: Changes pilot officer timelock from 5 hours as squad marine to 2 hours as DCC
/:cl:

https://media.discordapp.net/attachments/604397850675380234/1155395437256249354/image_4.png

I'm tired of new pilots who don't even read the guide only do direct firing without a laser detector, wipe the front with six minis, and don't even apologize afterwards. this ends now.
@github-actions github-actions bot added Config drag and drop Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Sep 24, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop to 2 hours pretty please, otherwise this is fine

@morrowwolf morrowwolf marked this pull request as draft September 24, 2023 07:13
changes from 5 - 2. anything for morrow.
@HumiliatedGoblin
Copy link
Contributor Author

Drop to 2 hours pretty please, otherwise this is fine

done!

@HumiliatedGoblin HumiliatedGoblin changed the title Makes Dropship Pilot Five Dropship Crew Chief hours, instead of Five Marine squad hours. Makes Dropship Pilot Two Dropship Crew Chief hours, instead of Five Marine squad hours. Sep 24, 2023
@morrowwolf morrowwolf removed the Config drag and drop label Sep 24, 2023
@morrowwolf morrowwolf marked this pull request as ready for review September 24, 2023 07:56
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I shouldn't review things at 4 AM.

Make a timelock type for dropships named like JOB_DROPSHIP_ROLES and have both PO and DCC hours count so people who have never played DCC don't have to go back.

@morrowwolf morrowwolf marked this pull request as draft September 24, 2023 08:00
@HumiliatedGoblin
Copy link
Contributor Author

OK I shouldn't review things at 4 AM.

Make a timelock type for dropships named like JOB_DROPSHIP_ROLES and have both PO and DCC hours count so people who have never played DCC don't have to go back.

I THINK that worked? I've never coded before, so tell me if I've missed anything.

@HumiliatedGoblin HumiliatedGoblin marked this pull request as ready for review September 24, 2023 13:04
@morrowwolf
Copy link
Member

TM'ing because I hate testing timelock stuff on local but looks good from code

@morrowwolf morrowwolf added this pull request to the merge queue Sep 26, 2023
Merged via the queue into cmss13-devs:master with commit 825d7dd Sep 26, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants