Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : divide survivor preset base on maps. #4522

Merged
merged 13 commits into from
Sep 28, 2023

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Sep 26, 2023

About the pull request

The idea is to divide this file into multiple files base on the maps.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: divide preset into different file for each map.
/:cl:

@github-actions github-actions bot added the Refactor Make the code harder to read label Sep 26, 2023
@Huffie56 Huffie56 marked this pull request as ready for review September 26, 2023 16:25
@Huffie56 Huffie56 marked this pull request as draft September 27, 2023 07:16
Julien added 3 commits September 27, 2023 11:32
also reorganise main file
1- all the 7 standart survivor preset.
2- all the preset that serve as a base.
3- all the preset that aren't used or out of place.
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 27, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Sep 27, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Huffie56
Copy link
Contributor Author

i just conflicted with myself i think.....

@Huffie56 Huffie56 marked this pull request as ready for review September 27, 2023 09:56
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move forcon_survivors.dm to LV-522 folder

There are some synth surv types in synth.dm that should be moved to their new homes in the nightmare survs. I can remember: LV-522 FORCON synth, UPP 173/RECON synth, probably a PMC synth? I can't remember.

@morrowwolf morrowwolf marked this pull request as draft September 27, 2023 19:36
@Huffie56
Copy link
Contributor Author

UPP and PMC synth move to nightmare insert
CLF synth is used for spawned of CLF that aren't survivor...
most of synth.dm preset gear is used for different variation of survivor synths.

@Huffie56 Huffie56 marked this pull request as ready for review September 28, 2023 09:35
@morrowwolf
Copy link
Member

TM'ing (just in case) but otherwise looks good this is really good work Huffie thanks

@morrowwolf morrowwolf added this pull request to the merge queue Sep 28, 2023
Merged via the queue into cmss13-devs:master with commit a8db871 Sep 28, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Sep 28, 2023
@Huffie56 Huffie56 deleted the cleaning_survivor_dm_preset branch September 28, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants