Synthetic internal powercell #4559
Conversation
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
|
i though synths have milky blood . pretty sure winout it they would run non-optimally |
|
this took me two additional hours but i think its in a borderline perfect spot now |
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
along with that since you are touching their blood . when a synth looses all its blood and you try to revive it will instantly die . i would recomend adding maybe a "synthetic blood" to medbay or something so it can be replenished ? + also would be good if synth blood level showed up on the health analyzer
code/modules/mob/living/blood.dm
Outdated
| @@ -58,16 +62,22 @@ | |||
| var/word = pick("dizzy","woozy","faint") | |||
There was a problem hiding this comment.
you forgot this part
There was a problem hiding this comment.
it'll still say "You feel very dizzy/woozy/faint"
code/modules/mob/living/blood.dm
Outdated
| @@ -58,16 +62,22 @@ | |||
| var/word = pick("dizzy","woozy","faint") | |||
There was a problem hiding this comment.
it'll still say "You feel very dizzy/woozy/faint"
|
really the whole handle_blood proc should be offlaoded to /datum/species for /humans |
|
What do you mean it will still show woozy? 🤔 |
|
idk if you guys mean the syntax but both things work rn. I'll update what I think you are talking about. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Zonespace27
added
Feature
About the pull request
This PR should tackle two things:
revives #3589 from ghostsheet
Explain why it's good for the game
Synthetics should not be feeling woozy. They also shouldn't be going blind from bloodloss.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.https://cdn.discordapp.com/attachments/490668342357786645/1157856898834497536/image.png?ex=651a21c4&is=6518d044&hm=813abcc8be5fd02367499e24651c97b7f840d8bcbc557364c534f1c0a61f25f5&
https://cdn.discordapp.com/attachments/490668342357786645/1157856899132305529/image.png?ex=651a21c4&is=6518d044&hm=d9fb14dcaa5eb9fa8ad1280636a5f8f188a72e0e5045b892fc29192046acd139&
Changelog
🆑
add: Damage to Synthetic's internal causes debuffs, eventual powercell failure.(death)
fix: Synthetic's should no longer lose blood.
code: moves blood proc to human.dm from blood.dm with above changes.
/:cl: