Fixes binocs destroying while zoomed FOR REAL #4577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WAIT, I think I have a better solution with SIGNALS |
|
registering through another obj is kinda cursed i don't understand, can't you just make a /mob/proc/reset_zoom and call it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Alright Morrow coming at you again with a hacky solution to a bug.Due to how qdel callback works we don't get a user, if we're still zoomed though we feel we can assume that we are still in the direct contents of the user.I am, admittedly, very sleepy so there could be a blatantly obvious answer that I'm missing and I hope there is. I'm not sure if it would be worth climbing locs up to an area or turf or whatever.OK take two: still hacky? Maybe?
Either way fixes the issues of binocs being destroyed messing up your view as it has for ?years?
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Morrow
fix: Fixed binocs destroying while zoomed
/:cl: