Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFB property changes. #4590

Merged
merged 13 commits into from
Oct 21, 2023
Merged

DFB property changes. #4590

merged 13 commits into from
Oct 21, 2023

Conversation

kiVts
Copy link
Contributor

@kiVts kiVts commented Oct 5, 2023

About the pull request

part 2 out of 4
This does a big touch up on defibrillation property in research

Well, to start off, max_level = 1 was removed. It appears warcrimes forgot to remove it since process proc has benefits explicitly for higher levels. I would call it a bug(oversight rather).

Second: Ghosts get notified when the chem starts to try and defib you, so you dont just wonder how did you stand up, and pretty neat too.

Third: The >6 level of defib to apply healing like with actual item defib is too high, so we move requirement down to >1 but make it heal much, much worse at levels lower than 5.
eg it took 20 units to heal ~20 brute at level 3(you will literally perma lmao), at level 5, however, this will go at around 2.5 per life tick, level 8 will give 4 damage heal.
This is a balance change(buff) But hardly so since its research, Research is already neglecting most of the time this property.

Fourth: removes one letter var, This whole file is entombed with them but Im not doing that for now.

Explain why it's good for the game

Defib property is way too underused and crudely made. This fixes it, partially.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 kiVts
add: Ghosts get notified when they are being revived by DFB property
balance: DFB property healing threshold lowered, You can create DFB property higher than one.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Oct 5, 2023
@Diegoflores31
Copy link
Contributor

Also something that would be neat is if you could make it so DFB activates all the effects of EGN . Since it currently doesnt work

@Diegoflores31
Copy link
Contributor

Also consider lowering the price a bit because DFB costs like more than ciphering

@kiVts
Copy link
Contributor Author

kiVts commented Oct 5, 2023

rip

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to do this instead

@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 12, 2023
@Zonespace27 Zonespace27 marked this pull request as draft October 13, 2023 04:14
Co-authored-by: Zonespace <[email protected]>
@kiVts
Copy link
Contributor Author

kiVts commented Oct 13, 2023

Its not intentional and I think I just discarded the changes on accident

@kiVts kiVts marked this pull request as ready for review October 13, 2023 12:23
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 21, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 21, 2023
@Zonespace27 Zonespace27 removed the Stale beg a maintainer to review your PR label Oct 21, 2023
Merged via the queue into cmss13-devs:master with commit de5c696 Oct 21, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants