changed flyby tgui #4600
Merged
changed flyby tgui #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
requested changes
Oct 11, 2023
Co-authored-by: harryob <[email protected]>
fira
approved these changes
Oct 11, 2023
|
Isn't tested. Flyby is now coded as a destination, which lasts 30 seconds instead of 200 seconds. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This was tested, it introduced a regression. Flybys we're always coded as destinations. Behind the scenes the shuttle is forced to transit to it's existing landing zone. This work was too change how the UI tells the backend how to do this. |
|
There is no longer a cancel flyby button, is this intented? Our only option is to wait out the full 200+ seconds, and with a medevac'd marine this can be bad. |
TheGamerdk
added a commit
to TheGamerdk/cmss13
that referenced
this pull request
Oct 15, 2023
This reverts commit 9b31e08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Slight change to the TGUI for dropship flight controls. I've had feedback that it is a bit unintuitive. This change should resolve novice POs accidentally launching flyby in a panic.
Explain why it's good for the game
Better UIs make everyone happier.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
ui: tweaked flyby controls to make them in line with other destinations
/:cl: