Fixes Observer Death Messages being delayed #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Long standing bug - due to waiting for not one but two full database entities loading, the death message in dchat is delayed.
It's also symptomatic of a scheduling problem with DBQM as you can see deaths occuring in "batches" every couple seconds, indicating the queries are not processed timely - but this is out of scope for this PR.
Instead it just moves the observer logging to take place before DB ops.
Explain why it's good for the game
Feels less clunky.
Testing Photographs and Procedure
Just spawned stuff and abombed it.
Changelog
🆑
fix: deadchat death messages should now display immediately rather than being delayed a couple seconds.
/:cl: