Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shotgun tube toggle hotkey #4794

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Shotgun tube toggle hotkey #4794

merged 3 commits into from
Nov 6, 2023

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Oct 27, 2023

About the pull request

Adds hotkey to toggling multi magazine on multi tube shotgun.

Explain why it's good for the game

Having hotkeys for combat related actions is very important.

Changelog

🆑
add: added shotgun tube toggle hotkey
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Oct 27, 2023
if(.)
return
var/mob/living/carbon/human/human = user.mob
var/obj/item/weapon/gun/shotgun/pump/dual_tube/held_item = human.get_held_item()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check if what they're holding exists and is this type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also if client is valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also why all this isn't a case for other hotkeys?

Copy link
Contributor

github-actions bot commented Nov 5, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 5, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Nov 6, 2023
Merged via the queue into cmss13-devs:master with commit 2bf2540 Nov 6, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants