Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back NVG #4807

Closed
wants to merge 1 commit into from
Closed

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Oct 30, 2023

About the pull request

Re-adds NVG (Night Vision Goggles) back to gameplay, removes NVO (Night Vision Optics (visor thing)) from gameplay.

Explain why it's good for the game

Honestly, I was going to try to fix NVO, but in the end I decided it is not really worth it. Too many issues:

  1. Too inconvenient to use. Yeah switching between visors is a real pain.
  2. Too inconvenient to recharge. You need someone to bring recharger, otherwise you won't be able to use the NVO more than for few minutes.
  3. NVO are way less balanced. You can use the binoculars with NVO, which is a HUGE advantage out of nowhere. Also, you can't break NVO as a xeno, and I think being able to break NVGs was a nice little counterplay.
  4. It's really hard to tell if marine is using NVO, even if you know where to look. It's just 1 blinking pixel that doesn't really change the shape of the helmet. There is also some tiny green glow, but it's probably only relevant in HvH, as xeno you won't see it. Really, I was playing xeno for last months and I think I noticed NVO only once. The sprite is not very good either and it's also broken (it doesn't blink when you are facing north iirc).

While everything I mentioned can be fixed, I'm not sure it's worth it. Maybe NVO matches the aesthetics a little better, but it requires too much repairs to actually work and I'm not willing to spend that much time and energy fixing someone else's project (and I doubt that someone will fix it either). And I cannot make new sprites for NVO anyway. So this is why I propose a revert to the thing that worked flawlessly and everyone was happy with.

Testing Photographs and Procedure

I did not test it, but no one read this anyway.

Changelog

🆑 ihatethisengine
add: Night Vision Goggles are obtainable again.
del: Night Vision Optics are no longer obtainable.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Removal snap labels Oct 30, 2023
@realforest2001 realforest2001 added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Oct 30, 2023
@cuberound
Copy link
Contributor

kinda sad, being able to use it with binos was the only good part about NVO

@gitbirb
Copy link

gitbirb commented Nov 4, 2023

kinda sad, being able to use it with binos was the only good part about NVO

That part seems like an oversight during the change, not an intended benefit of NVO.

@Zonespace27 Zonespace27 added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 5, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 13, 2023
@github-actions github-actions bot closed this Nov 20, 2023
@Drulikar Drulikar reopened this Nov 20, 2023
@Nanu308
Copy link
Member

Nanu308 commented Nov 21, 2023

This just seems like a revert of a change Morrow made, and i am more in favor of Marines not having NVG's readily available at all since they are incredibly strong and darkness is meant to be in favor of the xenos.

This goes against that gameplay design entirely, so i am adding the DNM label to it because i personally do not wish to see this ingame.

@Nanu308 Nanu308 added the Do Not Merge If you merge this PR, I will annihilate you label Nov 21, 2023
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Nov 22, 2023
@ihatethisengine
Copy link
Contributor Author

ihatethisengine commented Nov 22, 2023

This just seems like a revert of a change Morrow made, and i am more in favor of Marines not having NVG's readily available at all since they are incredibly strong and darkness is meant to be in favor of the xenos.

This goes against that gameplay design entirely, so i am adding the DNM label to it because i personally do not wish to see this ingame.

Well, we have NVGs in one form or another for over a year (or two?) already, so unless you want to remove NVG (including Morrow's version) whatsoever, you should merge this PR since this version favors xenos way more:

  1. Can't use with binos (NVGs with binos is an insane advantage, not comparable to anything).
  2. Xenos can break NVGs, which gives them some counter-play.
  3. Sprite is way more obvious, so you can notice an NVG user before they start shooting you.

Only significant downside of Morrow's version is recharging, but it doesn't affect xeno gameplay directly. I am saying this as a certified xenomain. So again, unless you want to remove NVG whatsoever, this version is more fitting for the gameplay than Morrow's.

And yes, this is a revert, because Morrow's change is frankly half-baked.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 25, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 3, 2023
@github-actions github-actions bot closed this Dec 10, 2023
@iloveloopers

This comment was marked as off-topic.

github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request
Original NVG wouldn't allow you to use them with binos, but when Morrow
introduced helmet optics, for some reason he didn't carry over the
limitation. I don't know if it was intended or simply was an oversight.
Sadly my revert to NVGs
(#4807) didn't go through, but
I still believe that I was right about points I brought up in the PR, so
I am going to address them bit by bit now.

# Explain why it's good for the game
Using nightvision with anything that increases your field of view gives
an unreasonable advantage which should be limited only to specs and SGs.

# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->

<!-- !! If you are modifying sprites, you **must** include one or more
in-game screenshots or videos of the new sprites. !! -->

<details>
I did test it
</details>


# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
label your changes in the changelog. Please note that maintainers freely
reserve the right to remove and add tags should they deem it
appropriate. You can attempt to finagle the system all you want, but
it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Maintainers freely reserve the right to remove and add
tags should they deem it appropriate. -->

:cl: ihatethisengine
balance: night vision optics no longer can be used with binoculars.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Removal snap Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants