Sword Repaths and Sizing #4809
Merged
Sword Repaths and Sizing #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
Zonespace27
approved these changes
Nov 3, 2023
Zonespace27
added
the
Balance Approved
cm13-github
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Currently machetes, ceremonial swords and all the like fall under subtypes of /obj/item/weapon/claymore/mercsword
This PR changes it so the root path is /obj/item/weapon/sword, moving /obj/item/weapon/claymore/mercsword to be the root item, and repathing /obj/item/weapon/claymore to /obj/item/weapon/sword/claymore.
It also paths /obj/item/weapon/katana to /obj/item/weapon/sword/katana.
As part of this repathing, I have also unilaterally made all the sword subtypes large items instead of normal sized items. Previously only the machete was a large item however, considering a machete is likely to be shorter than a claymore or katana, this made little sense.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
code: Repathed sword weapons to a uniform /obj/item/weapon/sword
balance: All sword-type weapons are now Large items instead of Normal sized, to match machetes.
/:cl: