Makes rear dropship doors solid again and refactors multi door filler turf logic #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
Birdtalon
reviewed
Nov 4, 2023
|
You are supposed to see through lifeboats doors (which is a subtype of reardoor), so make sure it's working |
Yup, checked just in case, lifeboat doors work as they are supposed to |
harryob
requested changes
Nov 6, 2023
harryob
approved these changes
Nov 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes a bug with rear drop ship doors, which allowed people to see through them (you can see space for 1 tick on departure though, dunno how to fix this detail). Refactored filler turfs logic in door parent, so we can avoid redundant code.
Also removed some unnecessary code from door class.
Explain why it's good for the game
Bugs and old, unnecessary code bad, therefore they should be gone.
Testing Photographs and Procedure
Changelog
🆑 MrDas
fix: You can no longer see through solid rear drop ship doors.
code: Moved filler turf logic from almayer airlocks to its parent door.
/:cl: