/tg/ Status Effects Part 3A - Daze Refactor #4844
Conversation
github-actions
bot
added
Sprites
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
# About the pull request Depends on Part 2 (#4842), reopening of #4844 Refactors daze and speech problems handling to back them by new status_effect-s and traits, fixes a few bugs, and gets rid of an unused and horrible bay12 relic horsehead with snowflake speech handling This just generally makes it more reliable timewise and allows further interactions in the future :cl: code: Refactored Daze to use new Status backend fix: Dazed screen effect now applies immediately fix: Stuttering now starts properly when dazed del: Removed unused disabilities code del: Removed an old, goofy and unused decade old horse mask /:cl: --------- Co-authored-by: forest2001 <[email protected]>
About the pull request
Next episode of status_effects, this ports Dazed status and relevant odds and ends.
This includes and depends directly on Part 2 - #4842 - and should be handled after it. Use a github compare if you want to see the contents.
It also gets rid of a bunch of generally goofy and unused things like the horsehead and some disabilities.
Should fix a bunch of bugs in the process, and evidently create more.
Explain why it's good for the game
Fixes bugs. Instant fullscreen updates. Removals reduce maintaining surface. Moves over to new backend code.
Testing Photographs and Procedure
Tested walking, dazing fullscreens as xeno and human, expiring daze, relogging while under daze to make sure fullscreen stays, speaking while dazed
Changelog
🆑
code: Refactored Daze status effect to use status_effect-s
fix: Dazed screen effect will now display immediately when status is applied
fix: Speech problems such as stuttering will now always be checked, preventing issues where eg. Daze alone wouldn't trigger it
del: Removed unused disabilities in game code
del: Removed an unused goofy horsehead mask
/:cl: