Added Ability for Looping Sounds to be heard from further away. #4857
Conversation
Thanks to Drulikar for the suggested Documentation. Co-authored-by: Drathek <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
I am uncertain if these changes are actually doing anything. See #4858 (comment) Or at least as configured in that PR I am unable to tell a difference.
The changes in THIS PR do stuff. Before the added changes, the sounds would be heard from a pre-programmed distance and not further away. See reply here for videos showing enabled or disabled: |
I've been going to the other PR and then merging THIS branch into the other branch. I may have had moot changes on the other branch that are newer than the changes I made here. |
#4858) …jecting-looping-sounds branch made 5 November 2023 to work) #ATTENTION!!!!! Requires this PR to be approved first to work: #4857 # About the pull request Makes an alarm the pilots can use on alamo or normandy to tell ground forces "Hey I plan on taking off soon." # Explain why it's good for the game The ship takeoff sound to taking off is like 7 seconds. Ground combat is mad intense & people can miss people talking. So having that alarm may make it so people hear that they're leaving before the ship leaves. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> oh... </details> # Changelog :cl: add: Launch Announcement Alarm for dropships to notify ground forces of departure. /:cl: --------- Co-authored-by: Drathek <[email protected]>
Allows Looping Sounds to be heard from further away.
Explain why it's good for the game
allows for looping alarms to be proximity based and heard from more than 1 room away should one desire.
side note... I was eating pizza and there was hella black ash on the bottom. I think they burned garlic bread. It was nasty.
Testing Photographs and Procedure
screenshot a sound?
okay uhh... I uhh... adjusted settings and played a looping sound and walked away from it.
🆑
code: Added ability to have looping sounds from further away
/:cl: