-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ability to turn on and turn off a dropship alarm. (Requires pro… #4858
Added Ability to turn on and turn off a dropship alarm. (Requires pro… #4858
Conversation
…jecting-looping-sounds branch made 5 November 2023 to work)
Also added a sound. https://store.steampowered.com/app/1993730/Holy_Journey_of_Salvation/ |
Thanks to Drulikar for the suggested Documentation. Co-authored-by: Drathek <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stop_launch_announcement_alarm should also be automatically called when the dropship launches (its whatever if the PO wants to be goofy and turn it back on but it'll get old quick)
…utton is pressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after #4857 was squashed worked fine; changes appear to be working fine.
Added restriction and warning about playing the alarm when you're not on a landing pad
…om/hislittlecuzingames/cmss13 into Dropship-Launch-Announcement-Alarm
Made some adjustments. The alarm turns off as soon as you click launch. I also restricted the alarm to only be soundable when you are idle or the ship is on the landing pad recharging/refueling. I think it's ready for merge, so requesting review. |
May want to adjust it so that if queen interacts with the dropship console. The alarm gets disabled. It gets annoying after 3 minutes of it constantly. |
…jecting-looping-sounds branch made 5 November 2023 to work)
#ATTENTION!!!!!
Requires this PR to be approved first to work:
#4857
About the pull request
Makes an alarm the pilots can use on alamo or normandy to tell ground forces "Hey I plan on taking off soon."
Explain why it's good for the game
The ship takeoff sound to taking off is like 7 seconds.
Ground combat is mad intense & people can miss people talking. So having that alarm may make it so people hear that they're leaving before the ship leaves.
Testing Photographs and Procedure
Screenshots & Videos
oh...
Changelog
🆑
add: Launch Announcement Alarm for dropships to notify ground forces of departure.
/:cl: